Repository navigation
Conversation
Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Dylan-M
force-pushed
the
dylanmyers/bp-1324-output-delivery-count
branch
from
October 30, 2026 16:20
5f8b086 to
0e4d5de
Compare
1 of 2 tasks
Caleb-Hurshman
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Make
generator.countonly count a record once the destination has it, such as: a successful socket write, a Splunk ACK, or an OTLP export with nothing rejected. A record that fails or is dropped after it was queued is replaced so that a run ends with exactly the count delivered. Delivery is at least once, so a destination can receive duplicates.docs/finite-generation.mdlists the delivery point for each output.Breaking changes:
records_emittedis nowrecords_delivered.output.otlp-grpc.batchTimeout: 0and anoutput.hec.batchTimeoutof 0 or less. With HEC ACKs on, it also rejects anackPollIntervalorackTimeoutof 0 or less. Aprometheus-remote-writebatchTimeout: 0is rejected when a count is set.requestTimeout, as logs do, instead ofbatchTimeout.Stopno longer cancels an export in flight.stdout now buffers metrics and spans along with logs. Filegen replay retries a failed line up to three times after the rest of the pass, so retried lines arrive out of order. After the last retry it drops the line with an error log.
Permit.Forgothen lowers that cycle's count, so the run still ends.Checklist