Enhance table rendering and string handling for East Asian characters#12
Enhance table rendering and string handling for East Asian characters#12goweii wants to merge 4 commits into
Conversation
- Updated table.dart to use displayWidth for accurate column width calculation. - Modified pubspec.yaml to clean up dependency version formatting. - Added tests in string_test.dart for East Asian character display width and text wrapping. - Introduced a new test in table_test.dart to validate table rendering with East Asian characters.
|
Apologies for the late response. Thanks for the contribution. I tested this locally and it is not merge-ready yet.
The new East Asian tests are useful, but the width calculation change affects more than CJK text. Existing table output changes around characters like Could you please update the implementation so the existing table formatting tests continue to pass, while keeping the new East Asian table/string behavior covered? |
|
Thanks for the review and for pointing this out. I’ve updated the width calculation so East Asian ambiguous-width characters are treated as narrow by default. This keeps characters such as I verified the PR locally:
Please let me know if you’d like any further changes. |
2 participants
No description provided.