Skip to content

Enhance table rendering and string handling for East Asian characters #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goweii wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enhance table rendering and string handling for East Asian characters #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
977f14c
Enhance table rendering and string handling for East Asian characters
goweii Apr 5, 2026
0e077ca
Merge branch 'onepub-dev:main' into main
goweii Apr 5, 2026
331585a
Fix ambiguous Unicode width handling in table rendering
goweii May 30, 2026
db368eb
Merge branch 'main' into main
goweii May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/src/console.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,13 +358,12 @@ class Console {
int? width,
TextAlignment alignment = TextAlignment.left,
]) {
final textAsString = text.toString();
stdout.write(
textAsString.alignText(
width: width ?? textAsString.length,
alignment: alignment,
),
var textAsString = text.toString();
textAsString = textAsString.alignText(
width: width ?? textAsString.displayWidth,
alignment: alignment,
);
stdout.write(textAsString);
}

/// Reads a single key from the input, including a variety of control
Expand Down Expand Up @@ -715,8 +714,7 @@ class Console {
// invalid UTF-8, wait for more characters
continue;
}
if (buffer.getRenderWidth() + text.getRenderWidth() <=
bufferMaxLength) {
if (buffer.displayWidth + text.displayWidth <= bufferMaxLength) {
buffer = buffer.substring(0, index) + text + buffer.substring(index);
index += text.length;
}
Expand All @@ -727,7 +725,7 @@ class Console {
write(buffer); // allow for backspace condition
cursorPosition = Coordinate(
screenRow,
screenColOffset + buffer.substring(0, index).getRenderWidth(),
screenColOffset + buffer.substring(0, index).displayWidth,
);

if (callback != null) callback(buffer, key);
Expand Down
Loading