Repository navigation
docs: document the shared CMS GitHub App - #261
Conversation
Latest result Pull request merged. Final answersSession Pull request merged. Session GitHub is still calculating mergeability for this PR head. Session GitHub is still calculating mergeability for this PR head. Session GitHub is still calculating mergeability for this PR head. Session GitHub is still calculating mergeability for this PR head. Session GitHub is still calculating mergeability for this PR head. Session GitHub is still calculating mergeability for this PR head. Session Fixed Codex P1 and Pullfrog P1 sign-in outage by restoring `/sign-in` until the compatible ViteHub upgrade. Updated migration documentation and PR metadata, pushed 35be44b, and resolved the thread. OAuth runtime assertions, Nuxt preparation, focused lint, formatting, and diff checks passed. The pnpm wrapper aborted an automatic reinstall; direct Nuxt preparation succeeded. Awaiting hosted checks. Session Fixed Codex P1 and Pullfrog P1 sign-in outage by restoring `/sign-in` until the compatible ViteHub upgrade. Updated migration documentation and PR metadata, pushed 35be44b, and resolved the thread. OAuth runtime assertions, Nuxt preparation, focused lint, formatting, and diff checks passed. The pnpm wrapper aborted an automatic reinstall; direct Nuxt preparation succeeded. Awaiting hosted checks. Session Fixed Codex P1 and Pullfrog P1 sign-in outage by restoring `/sign-in` until the compatible ViteHub upgrade. Updated migration documentation and PR metadata, pushed 35be44b, and resolved the thread. OAuth runtime assertions, Nuxt preparation, focused lint, formatting, and diff checks passed. The pnpm wrapper aborted an automatic reinstall; direct Nuxt preparation succeeded. Awaiting hosted checks. |
|
The draft prerequisite is still reproducible at cb22285: the pinned ViteHub preview The required Local verification: |
onmax
changed the title
onmax
changed the title
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
comark-mathml
comark-media
comark-metrics
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-ui
comark-xref
comark-zoom
commit: |
|
The draft prerequisite now depends on vite-hub/vitehub#3004, which is still open and draft. At Please include #3004 in the compatible pilot preview and complete the consumer pin session's verification, then comment here. Dependency pin updates remain outside this PR's stated scope. The earlier e2e blocker is cleared: the supplied current-head |
Next step Current CI is green; the historical e2e failure is cleared. pnpm preparation hit an automatic-install guard; direct Nuxt preparation, focused lint, runtime assertions and diff checks passed. Reproduced the external prerequisite: preview 3726291 lacks built-in app Auth sign-in. No source changes were needed. Final answersSession Current CI is green; the historical e2e failure is cleared. pnpm preparation hit an automatic-install guard; direct Nuxt preparation, focused lint, runtime assertions and diff checks passed. Reproduced the external prerequisite: preview 3726291 lacks built-in app Auth sign-in. No source changes were needed. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
Queued Waiting for a worker slot. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
This Agent activity was superseded by a newer managed comment. |
14 similar comments
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dd4ce7601
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Merging this PR in the documented order removes the production OAuth entry point before the checked-in ViteHub version supplies its replacement.
Reviewed changes in all 3 commits through 4dd4ce76, covering the CMS sign-in route removal and the new operational documentation.
- Built-in sign-in migration — removes the handwritten
/sign-inroute in favor of ViteHub's Console app-auth flow. - CMS operations guide — documents the shared GitHub App, callback, private bindings, repository installation, and authorization boundaries.
🚨 The merge sequence creates a sign-in outage
This branch still pins ViteHub 3726291, where console.auth: "app" only validates an existing session and does not render the built-in app-auth sign-in flow. Because the docs deploy on every push to main, merging this PR before #262 deletes the only route that starts GitHub OAuth and leaves unauthenticated editors unable to enter the Console until the second PR is merged and deployed.
Technical details
# Keep an OAuth entry point throughout deployment
## Affected sites
- `docs/server/routes/sign-in.get.ts:1-22` — this PR deletes the current GitHub OAuth starter.
- `docs/modules/vitehub-pilot.ts:23-27` — the checked-in integration still removes ViteHub's Auth client because the deleted route was expected to handle sign-in.
- `pnpm-workspace.yaml:65-100` — ViteHub packages remain pinned to preview `3726291`; the built-in app-auth sign-in implementation is only introduced by stacked PR #262's upgrade.
## Required outcome
- No deployed revision may remove `/sign-in` before its checked-in ViteHub dependency and integration expose the replacement Console sign-in flow.
## Suggested approach
- Include #262's dependency/integration upgrade in this PR, or restack the changes so the upgrade lands while `/sign-in` still exists and delete the route only afterward.
## Evidence
- Pinned ViteHub app-auth access implementation: https://github.com/vite-hub/vitehub/blob/372629197024833920d15db2e076db0e86bcfb83/packages/vite-hub/src/console/auth.ts
- Pinned Console route setup: https://github.com/vite-hub/vitehub/blob/372629197024833920d15db2e076db0e86bcfb83/packages/vite-hub/src/console/vite.ts
- New built-in app-auth pages on current ViteHub: https://github.com/vite-hub/vitehub/blob/main/packages/vite-hub/src/console/auth.tsgpt-5.6-sol ｜ 𝕏
vite-hub
Bot
changed the title
|
For the Codex finding and Pullfrog finding, 35be44b restores the baseline |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review at 4dd4ce76, covering the restored OAuth fallback and its migration guidance.
- Retained OAuth entry point — restored
docs/server/routes/sign-in.get.tsso the currently pinned ViteHub preview still has a production GitHub sign-in path. - Clarified upgrade sequencing — updated
docs/CMS.mdto require keeping/sign-inuntil #262 supplies built-in Console app-auth sign-in.
gpt-5.6-sol ｜ 𝕏
onmax
changed the title
Document the reusable Personal Project CMS GitHub App, exact comark-ui callback, private runtime bindings, selected-repository installation, and reuse by other personal projects. The guide keeps OAuth sign-in separate from the Content Store token and preserves the existing team policy.
This PR retains the current
/sign-inroute and documents it accurately. Companion #262 upgrades ViteHub and switches the guide and route to built-in Console sign-in in the same revision, so each deployed revision has a working OAuth entry point.The final diff against main only changes
docs/CMS.md. The combined stack passes production docs build, docs typecheck, the real Better Auth OAuth smoke check, GitHub Store cache integration test, and Wrangler's worker deployment dry run.