Repository navigation
fix(docs): upgrade ViteHub preview and replace pilot workarounds - #262
Conversation
Latest result Pull request merged. Final answersSession Pull request merged. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. No repair needed: Pullfrog’s Node compatibility finding is already fixed. Focused Node checks for Wrangler normalization and GitHub caching, Python SQLite migration checks, targeted vp lint and formatting, and git diff --check passed. The checkout is clean. No current-head CI results were supplied; awaiting required checks. Session Pass interrupted; current webhook state retained. |
Next step Waiting for running checks before the next pass. Final answersSession Waiting for running checks before the next pass. |
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
comark-mathml
comark-media
comark-metrics
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-ui
comark-xref
comark-zoom
commit: |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
New pull request evidence is queued. |
|
This Agent activity was superseded by a newer managed comment. |
6 similar comments
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
|
This Agent activity was superseded by a newer managed comment. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the ViteHub preview upgrade, removal of local integration workarounds, Content route disablement, worker KV substitution, Comments schema migration, dependency patch cleanup, and cache regression coverage.
- Preview alignment — Every ViteHub package is pinned to the same published preview, and the obsolete h3, Cloudflare, prerender, optional dependency, and Workspace cache workarounds are removed.
- Worker integration — The remaining Nuxt module preserves the root Wrangler output redirect, while the exact
@vite-hub/kvruntime import is replaced with a deliberate disabled implementation that matches the installed Console contract. - Content exposure —
defineContent({ route: false })uses the preview's native 404 behavior for the public API without disabling internal Content use by the Console and Comments. - Comments migration — The forge and durable scope-counter tables match the installed Comments schema, and existing counters are seeded from preserved thread numbers.
- Regression coverage — The GitHub Store test now uses real Git blob hashes and passes against the upstream cache implementation; the docs application typecheck also passes.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Important
The new Node compatibility patch is bypassed by the final Nitro configuration, so the generated Worker opts out of nodejs_compat_v2 again.
Reviewed changes Reviewed the five commits added after the prior pullfrog review, covering Node compatibility inference, the ViteHub dependency patch, Worker dry-run CI coverage, and the stacked sign-in merge.
- Compatibility inference — Explicit
nitro.cloudflare.nodeCompatis removed so Nitro reads the root Wrangler compatibility date and flags. - ViteHub patch — The dependency patch removes ViteHub's redundant
nodejs_compat_v2addition when its Node-compat branch runs. - Worker validation — CI now performs
wrangler deploy --dry-runagainst the generated deployment redirect after docs generation. - Stacked sign-in merge — The merge commit selects the preview's built-in Console sign-in and leaves no additional file changes in this PR.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the Node compatibility fix added since the prior Pullfrog review.
- Final config normalization — Kept Nitro's Node compatibility build path enabled, then removed ViteHub's redundant
nodejs_compat_v2and Nitro'sno_nodejs_compat_v2from the generated Wrangler config before the root deployment redirect is written. - Deployment regression check — Added CI assertions for the exact final compatibility flags before the existing Wrangler dry-run.
- Patch cleanup — Removed the now-unnecessary ViteHub dependency patch and updated the maintenance note to describe the local generated-config normalization.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the E2E synchronization change added since the prior Pullfrog review.
- Hydration synchronization — Waited for Nuxt’s exposed application instance to finish hydration before programmatically clicking the landing-page link, preserving the test’s client-router coverage while removing the first-load race.
gpt-5.6-sol ｜ 𝕏
The docs used an old ViteHub preview with local Nuxt/Cloudflare shims, a Workspace cache patch, and a Content API blocking middleware. Pin every ViteHub package to the published main preview
2862ffe428dde04c5d64d76b7b26e5224a170e17and remove those workarounds.This preview includes the built-in Console app Auth sign-in from vite-hub/vitehub#3004 and the merged fixes from #3006, #3007, #3009, and #3010. The three earlier integration patches have been removed. Content uses
route: false; the remaining local module selects the docs Wrangler output from the monorepo root. The Comark Shiki grammar backport remains until upgrading Comark. A Nitro virtual module excludes the Console's unused Teams KV dependency from this worker and throws if it is used. Nitro builds with Node compatibility explicitly enabled. The Wrangler output module removes ViteHub's redundantnodejs_compat_v2flag and Nitro 2'sno_nodejs_compat_v2opt-out, leavingnodejs_compatand the modern compatibility date to select the required Node APIs. CI asserts those final flags before validating the Cloudflare worker withwrangler deploy --dry-run. Patch removal instructions are inpatches/README.md.#261 is merged; this PR now targets
main. The existing/sign-inroute was retained in #261; this PR removes it and updatesdocs/CMS.mdin the same revision as the ViteHub upgrade. Both deployments therefore retain a working OAuth entry point.Migration
0001_comments-preview.sqladds the Comments forge map and scope counter tables, seeding counters from existing thread numbers. It was tested against the previous schema and applied through Executor to the production D1 database before merging; the migration journal and preserved thread numbers were verified.Validation:
nodejs_compatand neither v2 override. Localwrangler deploy --dry-runpassed with that config and worker bundle.