Deviation for Transport Security flag#5490
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue with Cisco platforms regarding gRPC transport security settings. By introducing a new deviation flag, the system can now correctly identify and bypass unsupported configurations, preventing test failures. Additionally, the PR includes minor improvements to test logging and diagnostic capabilities for container connectivity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a new deviation, grpc_transport_security_false_unsupported, which is used in the CreateGNMIServer configuration plugin to ensure transport security is enabled on unsupported devices. The changes include updates to the metadata proto, generated Go code, and the deviation accessor. Furthermore, the container connectivity test was updated to include more detailed logging and container state inspection during dial retries. A review comment identifies that the new deviation accessor lacks a required issue tracker link, violating the repository's style guide.
| // GrpcTransportSecurityFalseUnsupported returns true if the device does not | ||
| // support setting transport-security to false under grpc-server config. | ||
| func GrpcTransportSecurityFalseUnsupported(dut *ondatra.DUTDevice) bool { |
There was a problem hiding this comment.
The deviation accessor function is missing a reference to an issue tracker. According to the repository style guide, all deviation accessors must include a URL link to an issue tracker (e.g., https://issuetracker.google.com/xxxxx) that tracks the eventual removal of the deviation.
References
- Add a comment to the accessor function containing a URL link to an issue tracker which tracks removal of the deviation. The format should be https://issuetracker.google.com/xxxxx. (link)
2 participants
Summary
This change introduces a Cisco-specific deviation for gRPC transport security handling.
Problem
Cisco platforms do not support setting gRPC transport security to false.
Why This Change Is Needed
Without a platform-aware override, generated gNMI server configuration can request an unsupported value and cause test failures.
What Changed
grpc_transport_security_false_unsupported.