Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions feature/gnmi/tests/gnmi_ni_test/metadata.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ platform_exceptions: {
}
deviations: {
default_ni_gnmi_server_name: "gnxi-default"
grpc_transport_security_false_unsupported: true
}
}
platform_exceptions: {
Expand Down
3 changes: 3 additions & 0 deletions internal/cfgplugins/system.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ func CreateGNMIServer(t testing.TB, d *ondatra.DUTDevice, batch *gnmi.SetBatch,
if !deviations.GrpcServerServicesUnsupported(d) {
gnmiServer.Services = []oc.E_SystemGrpc_GRPC_SERVICE{oc.SystemGrpc_GRPC_SERVICE_GNMI}
}
if deviations.GrpcTransportSecurityFalseUnsupported(d) {
gnmiServer.TransportSecurity = ygot.Bool(true)
}
gnmi.BatchUpdate(batch, gnmiServerPath.Config(), gnmiServer)
}

Expand Down
6 changes: 6 additions & 0 deletions internal/deviations/deviations.go
Original file line number Diff line number Diff line change
Expand Up @@ -2064,14 +2064,14 @@
// AcctzRecordFailCommandUnsupported returns true if the device does not support Acctz record for fail user
// Juniper: https://partnerissuetracker.corp.google.com/issues/500649430

func AcctzRecordFailCommandUnsupported(dut *ondatra.DUTDevice) bool {

Check failure on line 2067 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

exported function AcctzRecordFailCommandUnsupported should have comment or be unexported
return lookupDUTDeviations(dut).GetAcctzRecordFailCommandUnsupported()
}

// AcctzRecordFailCommandUnsupported returns true if the device does not support Acctz record for fail user
// Juniper: https://partnerissuetracker.corp.google.com/issues/500627000

func AcctzRecordFailGrpcUnsupported(dut *ondatra.DUTDevice) bool {

Check failure on line 2074 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

exported function AcctzRecordFailGrpcUnsupported should have comment or be unexported
return lookupDUTDeviations(dut).GetAcctzRecordFailGrpcUnsupported()
}

Expand All @@ -2088,7 +2088,7 @@
return lookupDUTDeviations(dut).GetGrpcServerServicesUnsupported()
}

// StaticRouteToNextHopGroupOCNotSupported returns true if device does not support oc state path static route to nexthop group

Check failure on line 2091 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function StaticRouteToNHGOCUnsupported should be of the form "StaticRouteToNHGOCUnsupported ..."
func StaticRouteToNHGOCUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetStaticRouteToNhgOcUnsupported()
}
Expand Down Expand Up @@ -2116,7 +2116,7 @@

// AcctzRecordSessionChannelIdUnsupported returns true if the device does not support Acctz record for fail user
// Juniper: https://partnerissuetracker.corp.google.com/issues/500627000
func AcctzRecordSessionChannelIdUnsupported(dut *ondatra.DUTDevice) bool {

Check failure on line 2119 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

func AcctzRecordSessionChannelIdUnsupported should be AcctzRecordSessionChannelIDUnsupported
return lookupDUTDeviations(dut).GetAcctzRecordSessionChannelIdUnsupported()
}

Expand Down Expand Up @@ -2147,30 +2147,30 @@
return lookupDUTDeviations(dut).GetEnableMplsStaticOnInterface()
}

// Device does not support secondary controller card CPU utilization

Check failure on line 2150 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function SecondaryControllerCardCpuUtilizationUnsupported should be of the form "SecondaryControllerCardCpuUtilizationUnsupported ..."
// Arista: https://issuetracker.google.com/issues/508666262
func SecondaryControllerCardCpuUtilizationUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetSecondaryControllerCardCpuUtilizationUnsupported()
}

// Device does not support secondary controller card memory utilization

Check failure on line 2156 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function SecondaryControllerCardMemoryUtilizationUnsupported should be of the form "SecondaryControllerCardMemoryUtilizationUnsupported ..."
// Arista: https://issuetracker.google.com/issues/508656197
func SecondaryControllerCardMemoryUtilizationUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetSecondaryControllerCardMemoryUtilizationUnsupported()
}

// Device does not support interface counters in fcs errors

Check failure on line 2162 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function InterfaceCountersInFcsErrorsUnsupported should be of the form "InterfaceCountersInFcsErrorsUnsupported ..."
// Arista: https://issuetracker.google.com/issues/508304903
func InterfaceCountersInFcsErrorsUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetInterfaceCountersInFcsErrorsUnsupported()
}

// Mpls static pseudowire returns true if oc is not supported

Check failure on line 2168 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function MplsStaticPseudowireOcUnsupported should be of the form "MplsStaticPseudowireOcUnsupported ..."
func MplsStaticPseudowireOcUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetMplsStaticPseudowireOcUnsupported()
}

// Vlan client encapsulation returns true if oc is not supported

Check failure on line 2173 in internal/deviations/deviations.go

View workflow job for this annotation

GitHub Actions / Static Analysis

comment on exported function VlanClientEncapsulationOcUnsupported should be of the form "VlanClientEncapsulationOcUnsupported ..."
func VlanClientEncapsulationOcUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetVlanClientEncapsulationOcUnsupported()
}
Expand All @@ -2196,3 +2196,9 @@
func LACPInterfaceMemberStateInterfaceUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetLacpInterfaceMemberStateInterfaceUnsupported()
}

// GrpcTransportSecurityFalseUnsupported returns true if the device does not
// support setting transport-security to false under grpc-server config.
func GrpcTransportSecurityFalseUnsupported(dut *ondatra.DUTDevice) bool {
Comment on lines +2200 to +2202
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The deviation accessor function is missing a reference to an issue tracker. According to the repository style guide, all deviation accessors must include a URL link to an issue tracker (e.g., https://issuetracker.google.com/xxxxx) that tracks the eventual removal of the deviation.

References
  1. Add a comment to the accessor function containing a URL link to an issue tracker which tracks removal of the deviation. The format should be https://issuetracker.google.com/xxxxx. (link)

return lookupDUTDeviations(dut).GetGrpcTransportSecurityFalseUnsupported()
}
4 changes: 4 additions & 0 deletions proto/metadata.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1342,6 +1342,10 @@ message Metadata {
// Juniper: https://partnerissuetracker.corp.google.com/issues/510547636
bool containerz_retrieve_logs_unsupported = 426;

// Device does not support setting transport-security to false under
// grpc-server config.
bool grpc_transport_security_false_unsupported = 427;

// Reserved field numbers and identifiers.
reserved 84, 9, 28, 20, 38, 43, 90, 97, 55, 89, 19, 36, 35, 40, 113, 131, 141, 173, 234, 254, 231, 300, 241, 49;
}
Expand Down
23 changes: 17 additions & 6 deletions proto/metadata_go_proto/metadata.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading