Skip to content

8325506: Ensure randomness is only read from provided SecureRandom object#4531

Open
GoeLin wants to merge 1 commit into
openjdk:masterfrom
GoeLin:gbp_8325506
Open

8325506: Ensure randomness is only read from provided SecureRandom object#4531
GoeLin wants to merge 1 commit into
openjdk:masterfrom
GoeLin:gbp_8325506

Conversation

@GoeLin

@GoeLin GoeLin commented Jun 19, 2026

Copy link
Copy Markdown
Member

Asserts.java: resolve import statements. Backported from 21.

This depends on JDK-8308474 and JDK-8279800. Whithout these, Deterministic.java fails. PRs backporting these are open. Will commit in proper order.



Progress

  • JDK-8325506 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325506: Ensure randomness is only read from provided SecureRandom object (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4531/head:pull/4531
$ git checkout pull/4531

Update a local copy of the PR:
$ git checkout pull/4531
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4531

View PR using the GUI difftool:
$ git pr show -t 4531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4531.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 19, 2026

Copy link
Copy Markdown

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport 8818eb408edccf760eab991915550f592acba710 8325506: Ensure randomness is only read from provided SecureRandom object Jun 19, 2026
@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 19, 2026
@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 19, 2026
@mlbridge

mlbridge Bot commented Jun 19, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 19, 2026

Copy link
Copy Markdown

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 20, 2026
@GoeLin

GoeLin commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

GHA failure: javac crashed. This can not be caused by this test improvement. Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant