Skip to content

8249159: Downport test rework for SSLSocketTemplate from 8224650#801

Open
jerboaa wants to merge 1 commit into
openjdk:masterfrom
jerboaa:8249159-SSLSocketTemplate-change
Open

8249159: Downport test rework for SSLSocketTemplate from 8224650#801
jerboaa wants to merge 1 commit into
openjdk:masterfrom
jerboaa:8249159-SSLSocketTemplate-change

Conversation

@jerboaa
Copy link
Copy Markdown
Contributor

@jerboaa jerboaa commented May 20, 2026

Please review this clean (modulo path changes) test-only patch to make another test-only patch for JDK-8246330 apply cleanly in OpenJDK 8u. The latter is in preparation for JDK-8284047 so that it applies better (and increases test coverage).

Testing:

  • sun/security/ssl, sun/net/www/protocol/https and javax/net/ssl tests. No change before/after patch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8249159 needs maintainer approval

Issue

  • JDK-8249159: Downport test rework for SSLSocketTemplate from 8224650 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/801/head:pull/801
$ git checkout pull/801

Update a local copy of the PR:
$ git checkout pull/801
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/801/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 801

View PR using the GUI difftool:
$ git pr show -t 801

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/801.diff

Using Webrev

Link to Webrev Comment

8249159: Downport test rework for SSLSocketTemplate from 8224650
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 20, 2026

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 7b3ad8bff951b9f1d7a2bbe6d54e960321b2760c 8249159: Downport test rework for SSLSocketTemplate from 8224650 May 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 20, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 20, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant