Skip to content

Fix skill directory name to match SKILL.md name field#19

Open
stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:add-skillsaw-linting
Open

Fix skill directory name to match SKILL.md name field#19
stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:add-skillsaw-linting

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented May 7, 2026 •
edited
Loading

Summary

  • Rename cluster-update/update-advisor/ to cluster-update/openshift-cluster-update-advisor/ to match the name field in SKILL.md frontmatter

Why the rename?

The agentskills.io spec requires the name field to match the parent directory name:

Must match the parent directory name

Test plan

  • uvx skillsaw -v passes locally after the rename

🤖 Generated with Claude Code

@openshift-ci openshift-ci Bot requested review from DavidHurta and mrunalp May 7, 2026 17:18
@stbenjam stbenjam mentioned this pull request May 7, 2026
Open
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented May 7, 2026

/test images

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented May 7, 2026

Ah github actions aren't enabled in openshift, only openshift-eng. will make this prow

@stbenjam @claude
Fix skill directory name to match SKILL.md name field
a09eb2f 
Rename cluster-update/update-advisor/ to
cluster-update/openshift-cluster-update-advisor/ to comply with the
agentskills.io specification, which requires the name field to match
the parent directory name.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stbenjam stbenjam force-pushed the add-skillsaw-linting branch from 2ccd809 to a09eb2f Compare May 7, 2026 20:43
@stbenjam stbenjam changed the title Add skillsaw linting and fix skill directory name Fix skill directory name to match SKILL.md name field May 7, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

@stbenjam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a09eb2f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam stbenjam mentioned this pull request May 7, 2026
Open
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 12, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stbenjam