Skip to content

OSDOCS-16945# CQA work Stor1-- non-graceful shutdown#106592

Open
lpettyjo wants to merge 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16945-non-graceful-shutdown
Open

OSDOCS-16945# CQA work Stor1-- non-graceful shutdown#106592
lpettyjo wants to merge 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16945-non-graceful-shutdown

Conversation

@lpettyjo

@lpettyjo lpettyjo commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@lpettyjo lpettyjo added this to the Continuous Release milestone Feb 13, 2026
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2026
@lpettyjo lpettyjo added merge-review-needed Signifies that the merge review team needs to review this PR and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2026
@ocpdocs-previewbot

Copy link
Copy Markdown

@openshift-ci

openshift-ci Bot commented Feb 13, 2026

Copy link
Copy Markdown

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2026
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 16, 2026
----
<1> <node_name> = name of the node that shut down non-gracefully
+
* `<node_name>` = name of the node that shut down non-gracefully

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the SSG: Use a simple sentence to explain or describe a single line of command, variable, option, or parameter.

Suggested change
* `<node_name>` = name of the node that shut down non-gracefully
Use the `<node_name>` to specify the node that shut down non-gracefully.

<1> <node_name> = name of the node that shut down non-gracefully
+
After the taint is applied, the volumes detach from the shutdown node allowing their disks to be attached to a different node.
* `<node_name>` = name of the node that shut down non-gracefully

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `<node_name>` = name of the node that shut down non-gracefully
Use the `<node_name>` to specify the node that shut down non-gracefully.

----
<1> <node_name> = name of the node that shut down non-gracefully
+
* `<node_name>` = name of the node that shut down non-gracefully

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `<node_name>` = name of the node that shut down non-gracefully
Use the `<node_name>` to specify the node that shut down non-gracefully.

@mburke5678

Copy link
Copy Markdown
Contributor

@lpettyjo A couple of nits. Otherwise LGTM.

@lpettyjo lpettyjo changed the title OSDOCS-16945# CQA work Storage-- non-graceful shutdown OSDOCS-16945# CQA work Stor1-- non-graceful shutdown Mar 5, 2026
@jeana-redhat

Copy link
Copy Markdown
Contributor

The branch/enterprise-5.0 label has been added to this PR.

This is because your PR targets the main branch and is labeled for branch/enterprise-4.22. And any PR going into main must also target the latest version branch (branch/enterprise-5.0).

If the update in your PR does NOT apply to version 5.0 onward, please re-target this PR to go directly into the appropriate enterprise- version branch or branches instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 branch/enterprise-5.0 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants