-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-16945# CQA work Stor1-- non-graceful shutdown #106592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lpettyjo
wants to merge
1
commit into
openshift:main
Choose a base branch
from
lpettyjo:OSDOCS-16945-non-graceful-shutdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,23 +7,25 @@ | |||||
| [id="persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure_{context}"] | ||||||
| = Adding an out-of-service taint manually for automatic volume detachment | ||||||
|
|
||||||
| [role="_abstract"] | ||||||
| To allow volumes to detach automatically from a node after a non-graceful node shutdown, you can add an out-of-service taint. | ||||||
|
|
||||||
| .Prerequisites | ||||||
|
|
||||||
| * Access to the cluster with cluster-admin privileges. | ||||||
|
|
||||||
| .Procedure | ||||||
|
|
||||||
| To allow volumes to detach automatically from a node after a non-graceful node shutdown: | ||||||
|
|
||||||
| . After a node is detected as unhealthy, shut down the worker node. | ||||||
|
|
||||||
| . Ensure that the node is shutdown by running the following command and checking the status: | ||||||
| + | ||||||
| [source,terminal] | ||||||
| ---- | ||||||
| $ oc get node <node_name> <1> | ||||||
| $ oc get node <node_name> | ||||||
| ---- | ||||||
| <1> <node_name> = name of the node that shut down non-gracefully | ||||||
| + | ||||||
| * `<node_name>` = name of the node that shut down non-gracefully | ||||||
| + | ||||||
| [IMPORTANT] | ||||||
| ==== | ||||||
|
|
@@ -34,22 +36,21 @@ If the node is not completely shut down, do not proceed with tainting the node. | |||||
| + | ||||||
| [IMPORTANT] | ||||||
| ==== | ||||||
| Tainting a node this way deletes all pods on that node. This also causes any pods that are backed by | ||||||
| statefulsets to be evicted, and replacement pods to be created on a different node. | ||||||
| Tainting a node this way deletes all pods on that node. This also causes any pods that are backed by statefulsets to be evicted, and replacement pods to be created on a different node. | ||||||
| ==== | ||||||
| + | ||||||
| [source,terminal] | ||||||
| ---- | ||||||
| $ oc adm taint node <node_name> node.kubernetes.io/out-of-service=nodeshutdown:NoExecute <1> | ||||||
| $ oc adm taint node <node_name> node.kubernetes.io/out-of-service=nodeshutdown:NoExecute | ||||||
| ---- | ||||||
| <1> <node_name> = name of the node that shut down non-gracefully | ||||||
| + | ||||||
| After the taint is applied, the volumes detach from the shutdown node allowing their disks to be attached to a different node. | ||||||
| * `<node_name>` = name of the node that shut down non-gracefully | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| + | ||||||
| .Example | ||||||
| After the taint is applied, the volumes detach from the shutdown node allowing their disks to be attached to a different node. | ||||||
| + | ||||||
| The resulting YAML file resembles the following: | ||||||
| The resulting YAML file resembles the following example file: | ||||||
| + | ||||||
| .Example node YAML file with out-of-service taint applied | ||||||
| [source, yaml] | ||||||
| ---- | ||||||
| spec: | ||||||
|
|
@@ -65,6 +66,7 @@ spec: | |||||
| + | ||||||
| [source, terminal] | ||||||
| ---- | ||||||
| $ oc adm taint node <node_name> node.kubernetes.io/out-of-service=nodeshutdown:NoExecute- <1> | ||||||
| $ oc adm taint node <node_name> node.kubernetes.io/out-of-service=nodeshutdown:NoExecute- | ||||||
| ---- | ||||||
| <1> <node_name> = name of the node that shut down non-gracefully | ||||||
| + | ||||||
| * `<node_name>` = name of the node that shut down non-gracefully | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
9 changes: 6 additions & 3 deletions
9
storage/persistent-storage-csi-vol-detach-non-graceful-shutdown.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| :_mod-docs-content-type: ASSEMBLY | ||
| [id="ephemeral-storage-csi-vol-detach-non-graceful-shutdown"] | ||
| = Detach volumes after non-graceful node shutdown | ||
| include::_attributes/common-attributes.adoc[] | ||
| :toc: | ||
| :toc-title: | ||
| :context: ephemeral-storage-csi-vol-detach-non-graceful-shutdown | ||
| include::_attributes/common-attributes.adoc[] | ||
|
|
||
| toc::[] | ||
|
|
||
| [role="_abstract"] | ||
| This feature allows drivers to automatically detach volumes when a node goes down non-gracefully. | ||
|
|
||
| toc::[] | ||
|
|
||
| include::modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-overview.adoc[leveloffset=+1] | ||
|
|
||
| include::modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc[leveloffset=+1] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the SSG: Use a simple sentence to explain or describe a single line of command, variable, option, or parameter.