Modernize vaultlocker for python 3.12+ and current hvac APIs#24
Open
Raven-182 wants to merge 2 commits into
Open
Modernize vaultlocker for python 3.12+ and current hvac APIs#24Raven-182 wants to merge 2 commits into
Raven-182 wants to merge 2 commits into
Conversation
- Replace deprecated `Client.auth_approle()` call with `Client.auth.approle.login()`. - Require `hvac>=0.10.6` at minimum, this adds support for `Client.auth.approle.login()`. - Replace `six.moves.configparser` with `configparser`. Signed-off-by: Raven Kaur <raven.kaur@canonical.com>
- Drop python 2 and legacy python 3 test environments and require Python 3.12 or newer. - Add tox and CI coverage for noble, resolute, and latest dependencies on python 3.12 and 3.14 - Remove the OpenStack upper constraints for dependencies - Test each dependency set against Vault 1.8, 1.18, and 2.0 - Update github action versions Signed-off-by: Raven Kaur <raven.kaur@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates vaultlocker to support python 3.12+ and current hvac releases.
Changes
Client.auth_approle()withClient.auth.approle.login().hvac>=0.10.6as the minimum supported version.sixdependency. A clean installation was failing with withModuleNotFoundError: No module named 'six'The old
auth_approle()method is not available in hvac 1.x or 2.x. hvac 0.10.6 introduced the namespaced AppRole API used here.The other hvac calls currently used by vaultlocker still work with hvac 2.x. KV API changes will be handled separately as part of the KV v2 work.
Testing
Manually verified the vaultlocker
encryptanddecryptflows against a real Vault instance.OPEN-4605