Draft
Conversation
ideaship
force-pushed
the
rl_drop_secure_yaml_warning
branch
2 times, most recently
from
b4deb34 to
b1f0c4c
Compare
Users following the deployment guide see the warning "There is no file terraform/secure.yaml, create one by using terraform/secure.yaml.sample as template" in their log output. This is confusing because the guide recommends application credentials, where the secret is already in clouds.yaml and no secure.yaml is needed. Remove the secure.yaml existence check from setup-testbed.py and delete terraform/secure.yaml.sample. The check was already non-fatal (warning + sleep, no exit) — a compromise from PR #1879 where it was noted that secure.yaml is optional for app credentials. A TODO to add smarter detection was left but never followed up on. The deployment guide now exclusively recommends application credentials (osism/osism.github.io#972). For production deployments, a more fine-grained check that validates credentials based on auth type would still be valuable. AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
force-pushed
the
rl_drop_secure_yaml_warning
branch
from
b1f0c4c to
c06e94b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users following the deployment guide see the warning "There is no file terraform/secure.yaml, create one by using terraform/secure.yaml.sample as template" in their log output. This is confusing because the guide recommends application credentials, where the secret is already in clouds.yaml and no secure.yaml is needed.
Remove the secure.yaml existence check from setup-testbed.py and delete terraform/secure.yaml.sample. The check was already non-fatal (warning + sleep, no exit) — a compromise from PR #1879 where it was noted that secure.yaml is optional for app credentials. A TODO to add smarter detection was left but never followed up on.
The deployment guide now exclusively recommends application credentials (osism/osism.github.io#972). For production deployments, a more fine-grained check that validates credentials based on auth type would still be valuable.