Fix BytesWarning in Path.convert when comparing bytes and str#3322
Closed
internet-dot wants to merge 1 commit intopallets:mainfrom
Closed
Fix BytesWarning in Path.convert when comparing bytes and str#3322internet-dot wants to merge 1 commit intopallets:mainfrom
internet-dot wants to merge 1 commit intopallets:mainfrom
Conversation
When allow_dash=True and rv is bytes, the check rv in (b'-', '-') raises BytesWarning under -bb mode because Python compares bytes against str. Fix by short-circuiting with isinstance check before the containment test. Fixes pallets#2877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When allow_dash=True and rv is bytes, the check
rv in (b"-", "-")raises BytesWarning under-bbmode because Python compares bytes against str.Fix by adding an isinstance check before the containment test so that bytes rv is only compared against bytes "-" and str rv against str "-".
Fixes #2877