Skip to content

Fix BytesWarning in Path.convert when comparing bytes and str #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
internet-dot wants to merge 1 commit into from
Closed

Fix BytesWarning in Path.convert when comparing bytes and str #3322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/click/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,12 @@ def convert(
) -> str | bytes | os.PathLike[str]:
rv = value

is_dash = self.file_okay and self.allow_dash and rv in (b"-", "-")
is_dash = (
self.file_okay
and self.allow_dash
and isinstance(rv, (bytes, str))
and rv in (b"-", "-")
)

if not is_dash:
if self.resolve_path:
Expand Down