Skip to content

sadr: upkeep 2026-10-25 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pid1 merged 2 commits into from
Oct 25, 2026
Merged

sadr: upkeep 2026-10-25 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4527ebf
sadr: pin Node 24.22.1 in CI
sadrbot[bot] Oct 25, 2026
92ff02c
sadr: pin the kosync image and KOReader test fixtures
sadrbot[bot] Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,18 @@ jobs:

- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: 24
# sadr: cooldown exception CVE-2026-105481 CVE-2026-105482 CVE-2026-105483 CVE-2026-106069 CVE-2026-106073 CVE-2026-106074 CVE-2026-111497, lift when 24.22.1 clears the cooldown
node-version: 24.22.1

# koreader/test-data holds leaves.epub and tall.pdf, whose partial-MD5
# digests are pinned in KOReader's own spec/unit/util_spec.lua. Checking
# against those is what proves the first sample offset is 0 and not 256.
- name: Fetch KOReader test fixtures
run: git clone --depth 1 https://github.com/koreader/test-data.git koreader-test-data
# koreader/test-data has no release tags. c3b5d06 is master on 2024-12-16.
run: |
git init -q koreader-test-data
git -C koreader-test-data fetch -q --depth 1 https://github.com/koreader/test-data.git c3b5d06e1ae8ea088bd898b0e7f9da3753d0d86c
git -C koreader-test-data checkout -q FETCH_HEAD

# --big writes a sparse file of 1 GiB + 1024 bytes to exercise the twelfth
# sample. ext4 on the runner allocates only the written extents.
Expand All @@ -45,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
services:
kosync:
image: koreader/kosync:latest
image: koreader/kosync:latest@sha256:bb3f13615365703315a43b9059f65e71e876440f867e23a42bf27f2fa18264e1
ports:
# 17200 is the plaintext listener. 7200 serves HTTPS with a
# self-signed certificate that Node's fetch rejects.
Expand All @@ -55,7 +60,8 @@ jobs:

- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: 24
# sadr: cooldown exception CVE-2026-105481 CVE-2026-105482 CVE-2026-105483 CVE-2026-106069 CVE-2026-106073 CVE-2026-106074 CVE-2026-111497, lift when 24.22.1 clears the cooldown
node-version: 24.22.1

- name: Wait for the reference server
run: |
Expand Down Expand Up @@ -133,7 +139,8 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: 24
# sadr: cooldown exception CVE-2026-105481 CVE-2026-105482 CVE-2026-105483 CVE-2026-106069 CVE-2026-106073 CVE-2026-106074 CVE-2026-111497, lift when 24.22.1 clears the cooldown
node-version: 24.22.1
- run: node --check verify.mjs
- run: node --check vectors/check.mjs
- run: node --check coverage.mjs
Expand Down
2 changes: 1 addition & 1 deletion reference-server/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Uses podman if present, otherwise docker. See README.md in this directory.
set -eu

IMAGE="${KOSYNC_IMAGE:-docker.io/koreader/kosync:latest}"
IMAGE="${KOSYNC_IMAGE:-docker.io/koreader/kosync:latest@sha256:bb3f13615365703315a43b9059f65e71e876440f867e23a42bf27f2fa18264e1}"
NAME="${KOSYNC_NAME:-kosync-ref}"
PORT="${KOSYNC_PORT:-8080}"

Expand Down
Loading