Repository navigation
sadr: upkeep 2026-10-25 - #4
Merged
Merged
Conversation
node-version: 24 resolves to 24.22.1 today. Sadr pins that exact version, a security release still inside the 7-day cooldown, as a cooldown exception.
The reference image koreader/kosync:latest (v2.1.1, built 2026-05-16) is pinned by digest in CI and in reference-server/run.sh. The koreader/test-data clone in CI fetches commit c3b5d06, because the repo has no release tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
CI now pins every runtime, image and cloned repo it installs, so a CI run installs the same bits each time. Node moves from the floating
24to the exact release it resolves to today, and the reference image and the KOReader fixtures are pinned too.Changes
referenceservice (.github/workflows/conformance.yml) and as the default image of reference-server/run.shSupply chain
Security findings
Holds
AGENTS.md
Merging
Needs you
Verification
node --checkon verify.mjs, vectors/check.mjs and coverage.mjs (Node 24.22.1): passednode coverage.mjs: "OK — spec and verifier agree", 48 assertionsnode vectors/check.mjs --big --koreader <koreader/test-data at c3b5d06>: 10 passed, 0 failednode verify.mjs --help: exit 2, as CI expectssh reference-server/run.sh startwith the pinned image, thennode verify.mjs … --strict-accept --second-user ciuser2as the CIreferencejob runs it: conformant, 49 passed, 0 MUST failures, 2 SHOULD failures (same as the README table)pins.py check .github/workflows/*.yml: no problemsgitleaks giton the full history and on this branch: no leakssemgrep ci --dry-runon main and on this branch: the same 3 findings, all already triaged in SemgrepRun
Not done or not checked
schedulerun of conformance.yml existed to notice a change in koreader/kosync:latest. With the digest pin, a new reference image reaches CI only when a later Sadr run moves the digest, after a 7-day cooldown. If you want the image to float, add a### Don't touchline for it to AGENTS.md.Opened by Sadr, a dark factory for software.