docs(idp): use placeholder request params and warn on reserved keys#2318
Merged
Conversation
The Identity Provider Request Params example used the reserved OAuth parameters client_id, response_type, and redirect_uri as their own values. Users copied these literally into their config, overriding the values Pomerium sets itself during the OAuth 2.0 code flow and breaking sign-in (ENG-4222). Replace the example with neutral placeholder values and add a warning listing the parameters Pomerium manages that must not be set here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nickytonline
approved these changes
Jul 16, 2026
This was referenced Jul 16, 2026
desimone
approved these changes
Jul 16, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Identity Provider Request Params reference used the reserved OAuth parameters
client_id,response_type, andredirect_urias their own example values. Because these looked like real settings, users copied them literally into their config — overriding the values Pomerium sets itself during the OAuth 2.0 code flow and breaking sign-in.This change:
foo: bar,baz: qux) in both the config-file and environment-variable snippets, so nothing in the example is copy-pasteable into a broken state.client_id,response_type,redirect_uri,scope,state,nonce) that must not be set here, and clarifies this setting is for additional provider-specific parameters (e.g.prompt,access_type).Related
AI disclosure
Claude Code made the documentation edits and drafted this PR; I reviewed and directed the changes.
Checklist