Merged
Conversation
f9fa419 to
af269e3
Compare
af269e3 to
fc383f5
Compare
fc383f5 to
9cd009e
Compare
micprog
reviewed
Apr 2, 2026
Member
micprog
left a comment
There was a problem hiding this comment.
Love the upgrade, there look to be some nice usability and styling improvements! I have some questions about some of the implementation, see comments.
Contributor
Author
|
Thanks a lot for the thorough review! I fixed all your suggestions where possible, see comments. |
f0bdec7 to
4fecc74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous error implementation is outdated: both
causeanddescriptionhave been deprecated since a while in the standard library. This PR modernizes the error type and handlingAdopting
mietteerror typeThe new global error type is now
miette::Report, which has the following benefits:Diagnostics.miette::Reporthas neat macros likebail!,ensure!andmiette!(inspired byanyhow)wrap_err(resp.wrap_err_withfor lazy evaluation), which additionally has the advantage that the source is retained with the standardsource()which allows to traverse the whole chain of errors and print it out.Suppressible errors
An additional
downgrade_if_suppressed()function has been introduced to support downgrading errors to warnings. The suppressible errors are duplicated in anErrorsenum with corresponding variants inWarnings. Then, the call site of the error can simply do:Restructuring
Additionally
error.rshas been removed entirely, and the rest (e.g.stageln!and other macros) moved to thediagnostic.rs, where they also belong imo.