Fix CRN and SODAPRO test failures with pandas 3 StringDtype#2729
Closed
joaquinhuigomez wants to merge 1 commit intopvlib:mainfrom
Closed
Fix CRN and SODAPRO test failures with pandas 3 StringDtype#2729joaquinhuigomez wants to merge 1 commit intopvlib:mainfrom
joaquinhuigomez wants to merge 1 commit intopvlib:mainfrom
Conversation
Member
|
I don't think turning off all dtype checks is the best approach here. It made sense in #2668 because those dataframes have only a few columns with controlled outputs. The situation is more complex in iotools where we're ingesting outside data. I have a PR in the works to fix #2728, so I'm closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iotoolstest failures with pandas 3 #2728 (partial: StringDtype failures only)pandas 3 infers string columns as
StringDtypeinstead ofobject, causing dtype mismatches in CRN (CRX_VN,ST_TYPE) and SODAPRO (Observation period) test assertions. This addscheck_dtype=Falseto the affectedassert_frame_equalcalls, matching the approach used in #2668 for solar position tests. The remaining failures in #2728 (timezone-related) are covered by #2343.