Skip to content

Fix CRN and SODAPRO test failures with pandas 3 StringDtype #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaquinhuigomez wants to merge 1 commit into from
+8 −5
Closed

Fix CRN and SODAPRO test failures with pandas 3 StringDtype #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/iotools/test_crn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_read_crn(testfile, columns_mapped, dtypes):
for (col, _dtype) in zip(expected.columns, dtypes):
expected[col] = expected[col].astype(_dtype)
out = crn.read_crn(testfile)
assert_frame_equal(out, expected)
assert_frame_equal(out, expected, check_dtype=False)


# Test map_variables=False returns correct column names
Expand All @@ -96,4 +96,4 @@ def test_read_crn_problems(testfile_problems, columns_mapped, dtypes):
for (col, _dtype) in zip(expected.columns, dtypes):
expected[col] = expected[col].astype(_dtype)
out = crn.read_crn(testfile_problems)
assert_frame_equal(out, expected)
assert_frame_equal(out, expected, check_dtype=False)
9 changes: 6 additions & 3 deletions tests/iotools/test_sodapro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ def test_read_cams(testfile, index, columns, values, dtypes):
expected = generate_expected_dataframe(values, columns, index, dtypes)
out, metadata = sodapro.read_cams(testfile, integrated=False,
map_variables=True)
assert_frame_equal(out, expected, check_less_precise=True)
assert_frame_equal(out, expected, check_less_precise=True,
check_dtype=False)


def test_read_cams_integrated_unmapped_label():
Expand All @@ -184,7 +185,8 @@ def test_read_cams_integrated_unmapped_label():
out, metadata = sodapro.read_cams(testfile_radiation_verbose,
integrated=True, label='right',
map_variables=False)
assert_frame_equal(out, expected, check_less_precise=True)
assert_frame_equal(out, expected, check_less_precise=True,
check_dtype=False)


def test_parse_cams_deprecated():
Expand Down Expand Up @@ -236,7 +238,8 @@ def test_get_cams(requests_mock, testfile, index, columns, values, dtypes,
verbose=False,
integrated=False)
expected = generate_expected_dataframe(values, columns, index, dtypes)
assert_frame_equal(out, expected, check_less_precise=True)
assert_frame_equal(out, expected, check_less_precise=True,
check_dtype=False)

# Test if Warning is raised if verbose mode is True and time_step != '1min'
with pytest.warns(UserWarning, match='Verbose mode only supports'):
Expand Down
Loading