Fix HNOCA kernel to be the squared Jarrad kernel#65
Merged
Marius1311 merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
The HNOCA kernel should equal the Jarrad kernel squared. The base expression before squaring was using `2 * n_neighbors` in the denominator, but Jarrad uses `4 * n_neighbors`. Aligning the denominator makes HNOCA = Jarrad^2, faithful to the original HNOCA-tools implementation. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
FYI @zhisonghe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 13 13
Lines 1387 1387
=======================================
Hits 1198 1198
Misses 189 189
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Summary
2 * n_neighborsto4 * n_neighbors, making HNOCA exactly the Jarrad kernel squaredDetails
The HNOCA kernel is defined as the Jarrad kernel squared. The Jarrad kernel normalizes overlap as:
Previously, the HNOCA base expression used
2kinstead of4kbefore squaring, which deviated from the original HNOCA-tools implementation. This single-character fix aligns it correctly.