Skip to content

Fix HNOCA kernel to be the squared Jarrad kernel #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marius1311 merged 1 commit into from
Apr 1, 2026
Merged

Fix HNOCA kernel to be the squared Jarrad kernel #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cellmapper/model/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def compute_kernel_matrix(
if kernel_method == "jaccard":
kernel_matrix.data /= 4 * n_neighbors - kernel_matrix.data
elif kernel_method == "hnoca":
kernel_matrix.data /= 2 * n_neighbors - kernel_matrix.data
kernel_matrix.data /= 4 * n_neighbors - kernel_matrix.data
kernel_matrix.data = kernel_matrix.data**2

elif kernel_method in PackageConstants.CONNECTIVITY_BASED_KERNELS:
Expand Down
Loading