Add JaCoCo code coverage reporting with Codecov integration

[Copilot]

Integrates JaCoCo coverage instrumentation into the Maven build and wires it up to Codecov via GitHub Actions.

pom.xml

• Add jacoco-maven-plugin 0.8.15 with prepare-agent (test-time instrumentation) and report (package phase) executions
• Exclude generated message classes (quickfixj-messages/quickfixj-messages-*/target/classes/**) from the coverage report
• Add @{argLine} to maven-surefire-plugin configuration — required so the JaCoCo Java agent is actually passed to the JVM running tests; without this no coverage data is collected

README.md

• Add Codecov badge.

maven.yml

• The test job now has a Codecov upload step with if: matrix.os == 'ubuntu-latest' && matrix.java == 21, so only that combination uploads results.

Prerequisites: register the repository on codecov.io and store the upload token as a repository secret named CODECOV_TOKEN.

[chrjohn]

@copilot is there the possibility to only create the coverage report selectively, i.e. on the nightly build?

[Copilot]

@copilot is there the possibility to only create the coverage report selectively, i.e. on the nightly build?

Yes — JaCoCo is now gated behind a coverage Maven profile (commit refactor: move JaCoCo to a coverage Maven profile):

• pom.xml: the jacoco-maven-plugin (prepare-agent + report) is in a coverage profile (activeByDefault=false). A default empty <argLine/> property is added so the @{argLine} surefire config expands safely when the profile is not active.
• nightly-build.yml: -P"coverage" is added to the Build SNAPSHOT command — this is the only place JaCoCo runs.
• maven.yml (regular CI): unchanged — JaCoCo is never activated there.

[chrjohn]

@copilot Non-parseable POM /Users/runner/work/quickfixj/quickfixj/pom.xml: end tag name must match start tag name from line 437 (position: TEXT seen ...\n\t\t\t... @455:14) @ line 455, column 14

[Copilot]

@copilot Non-parseable POM /Users/runner/work/quickfixj/quickfixj/pom.xml: end tag name must match start tag name from line 437 (position: TEXT seen ...</executio...

Fixed in the latest commit. The edit that moved JaCoCo into a profile accidentally dropped the </plugin> closing tag for maven-enforcer-plugin, leaving </plugins> where </plugin> was expected.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[chrjohn]

@copilot please move the codecov upload from the nightly build to the normal maven.yml. I think it needs to be there to correctly analyze PRs.

[Copilot]

@copilot please move the codecov upload from the nightly build to the normal maven.yml. I think it needs to be there to correctly analyze PRs.

Done. A dedicated coverage job has been added to maven.yml (commit refactor: move Codecov upload from nightly build to maven.yml coverage job). It runs on ubuntu-latest with JDK 21, activates -P"coverage", and uploads to Codecov — so it will trigger on both pushes to production branches and on PRs. The Codecov upload and coverage profile have been removed from nightly-build.yml.

[chrjohn]

@copilot please change maven.yml so that there is no separate job where coverage data is uploaded. Instead, use only the "ubuntu-latest" job on JDK 21 for uploading coverage data. Coverage data can be generated on each job, so we do not need the "coverage" profile anymore.

[Copilot]

@copilot please change maven.yml so that there is no separate job where coverage data is uploaded. Instead, use only the "ubuntu-latest" job on JDK 21 for uploading coverage data. Co...

Done (commit refactor: move JaCoCo to main build; upload coverage from ubuntu/JDK21 test job):

• pom.xml: JaCoCo prepare-agent + report moved from the coverage profile into the main <build><plugins> section — runs on every job. The coverage profile is removed.
• maven.yml: The separate coverage job is removed. The test job now has a Codecov upload step with if: matrix.os == 'ubuntu-latest' && matrix.java == 21, so only that combination uploads results.

[the-thing]

@chrjohn

Seems that messages are still included, which is probably not desired?

[chrjohn]

@the-thing I still need to get used to their UI. Do you mean the golden source files?
I excluded

<exclude>quickfixj-messages/quickfixj-messages-*/target/classes/**</exclude>

[the-thing]

Yes, but it seems like it is not being picked up? Shows 0% for quickfixj-messages/quickfixj-messages-fixlatest/src/test/resources/golden/fixlatest/quickfix , I think it should not be there if excluded.

[chrjohn]

@the-thing #1286