fix: restore quickfixj-core JaCoCo coverage and exclude generated message modules

[Copilot]

Two coverage bugs introduced in #1285: quickfixj-core tests produced no coverage data, and generated message classes (mapped to src/test/resources/golden/ source files by Codecov) appeared in the report despite the intent to exclude them.

quickfixj-core/pom.xml — JaCoCo agent not reaching the test JVM

Both surefire-java8 and surefire profiles override <argLine> with concrete JVM flags but omit @{argLine}. A non-empty child override replaces the parent's value entirely, discarding the JaCoCo agent. quickfixj-base happened to work because its profiles use an empty <argLine>, which Maven leaves unset and falls back to the parent's @{argLine}.

<!-- before -->
<argLine>-Xmx2g -Djava.net.preferIPv4Stack=true</argLine>

<!-- after -->
<argLine>@{argLine} -Xmx2g -Djava.net.preferIPv4Stack=true</argLine>

quickfixj-messages/pom.xml — message modules generating unwanted reports

JaCoCo reported coverage for generated quickfix.fixlatest.* / quickfix.field.* classes. Codecov then resolved their SourceFile attributes to the identically-named .java files under src/test/resources/golden/, making those golden files appear as covered source. The existing <excludes> in the root pom was using filesystem paths (quickfixj-messages/quickfixj-messages-*/target/classes/**) — JaCoCo report excludes require class-name patterns — so it never filtered anything.

Simplest correct fix: skip JaCoCo entirely for all message sub-modules (generated code, no meaningful coverage value) via their shared parent pom, and remove the broken <excludes> from the root pom.

<!-- quickfixj-messages/pom.xml -->
<plugin>
    <groupId>org.jacoco</groupId>
    <artifactId>jacoco-maven-plugin</artifactId>
    <configuration>
        <skip>true</skip>
    </configuration>
</plugin>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.22%. Comparing base (9b58948) to head (33530dc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##             master    #1286       +/-   ##
=============================================
+ Coverage     42.85%   70.22%   +27.37%     
- Complexity      684     2242     +1558     
=============================================
  Files           125      163       +38     
  Lines          3794     9076     +5282     
  Branches        359     1192      +833     
=============================================
+ Hits           1626     6374     +4748     
- Misses         2021     2238      +217     
- Partials        147      464      +317     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[the-thing]

Also maybe.

if: matrix.os == 'ubuntu-latest' && matrix.java == 21
=>
if: matrix.os == 'ubuntu-latest' && matrix.java == 21 && github.repository == 'quickfix-j/quickfixj'

[chrjohn]

Also maybe.

if: matrix.os == 'ubuntu-latest' && matrix.java == 21 => if: matrix.os == 'ubuntu-latest' && matrix.java == 21 && github.repository == 'quickfix-j/quickfixj'

@the-thing good point, but isn't upload prevented anyway since other repo does not have the secret?

[the-thing]

Yes, but I don't remember if build fails silently or the whole build fails.

[chrjohn]

@the-thing added, thanks.