Skip to content

fix: restore quickfixj-core JaCoCo coverage and exclude generated message modules #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 2 commits into from
Jul 25, 2026
+15 −8
Merged

fix: restore quickfixj-core JaCoCo coverage and exclude generated message modules #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ca18b7
fix: restore JaCoCo coverage for quickfixj-core and exclude message m…
Copilot Jul 25, 2026
33530dc
Add repository condition for Codecov upload
chrjohn Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Test with Maven
run: ./mvnw install -B -V -D"maven.javadoc.skip"="true" -P"skipBundlePlugin,minimal-fix-latest" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120"
- name: Upload coverage reports to Codecov
if: matrix.os == 'ubuntu-latest' && matrix.java == 21
if: matrix.os == 'ubuntu-latest' && matrix.java == 21 && github.repository == 'quickfix-j/quickfixj'
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
5 changes: 0 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,11 +470,6 @@
<goals>
<goal>report</goal>
</goals>
<configuration>
<excludes>
<exclude>quickfixj-messages/quickfixj-messages-*/target/classes/**</exclude>
</excludes>
</configuration>
</execution>
</executions>
</plugin>
Expand Down
4 changes: 2 additions & 2 deletions quickfixj-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>
-Xmx2g -Djava.net.preferIPv4Stack=true
@{argLine} -Xmx2g -Djava.net.preferIPv4Stack=true
</argLine>
<trimStackTrace>false</trimStackTrace>
<includes>
Expand Down Expand Up @@ -321,7 +321,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>
-Xmx2g -Djava.net.preferIPv4Stack=true
@{argLine} -Xmx2g -Djava.net.preferIPv4Stack=true
--add-opens java.base/java.lang=ALL-UNNAMED
</argLine>
<trimStackTrace>false</trimStackTrace>
Expand Down
12 changes: 12 additions & 0 deletions quickfixj-messages/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@
<generator.decimal>false</generator.decimal>
</properties>

<build>
<plugins>
<!-- Message classes are generated code; exclude them from JaCoCo coverage entirely. -->
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

<modules>
<!-- The order in which these modules is run is significant
Expand Down
Loading