fix(ci): fetch llama-server sidecar before lint in release publish job#261
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.15.0 release-please publish run failed:
binaries/llama-server-aarch64-apple-darwin doesn't exist. Thebuild-and-releasejob ranLint and format check(which compilesbuild.rsviacargo clippy) before the llama-server sidecar was present. ItsCache llama.cpp sidecarstep only restored from cache (no fetch on miss) and sat after lint/test, so the first-ever release run hit a cache miss with no sidecar and exited 101. The same bug was already fixed innightly-release.yml(#235) and is correct inpr-build-validation.yml; this job never got the patch because it had never run until the first real release.As a result, the v0.15.0 GitHub release was created but published with no assets.
Key changes
Cache llama.cpp sidecarahead of lint/typecheck/test and add aFetch llama-server sidecarstep (bun run engine:ensure) so the sidecar exists before anycargoinvocation. Mirrorsnightly-release.ymlandpr-build-validation.yml.workflow_dispatchtrigger (with ataginput) so the build/publish job can be re-run to attach assets to an existing release tag after a failed run. The build job now runs on dispatch and falls back toinputs.tagfor the release tag; checkout uses the tag's source. This is the same resilience the nightly workflow already has.Testing
CI-workflow-only change; no app code touched. YAML validated. The fix path is already proven green by the identical sidecar-fetch ordering in
nightly-release.ymlandpr-build-validation.yml.