Repository navigation
fix(signer): preserve asynchronous request body handoff - #29
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #25
Summary
A custom signer returning the input request or a clone could have its upload body closed as soon as the base RoundTrip returned. The base transport can legally finish reading afterward, so asynchronous uploads failed.
Transfer cleanup to the signed body's Close after handoff, sharing idempotent closure for input-body aliases. Signing failures still close the input; empty signed bodies preserve net/http framing. Document the resulting body lifetime.
Testing
Risks and compatibility
The public API is unchanged. Input cleanup after successful handoff now follows the base transport's body closure; custom RoundTrippers must honor Go's existing obligation to close request bodies, including on error. Standalone Sign ownership is unchanged.
Release notes
Checklist