Repository navigation
Conversation
Check for shiny with rlang::check_installed(), including when reactlog_show() or reactlog_widget() use the default log. Use cli::cli_abort() and cli::cli_warn() for reactlog_disable() and log version errors, and report them from the function the user called. Switch to testthat 3rd edition for snapshot tests.
schloerke
added this pull request to stack #163
October 22, 2026 20:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses rlang and cli for the package's own errors and warnings.
assert_shiny_version()now callsrlang::check_installed("shiny", version = ...), which also offers to install or upgrade shiny in an interactive session.reactlog_show()andreactlog_widget()check for shiny when called with the defaultlog, instead of failing with "there is no package called 'shiny'".reactlog_render()usesrlang::is_installed()in place ofrequireNamespace().reactlog_disable()and the log version checks now usecli::cli_abort()/cli::cli_warn()with bullets. The version errors are reported from the function the user called (such asreactlog_render()), not the internalreactlog_upgrade().cliis added to Imports.Adds snapshot tests for the new messages, so the package now uses testthat's 3rd edition (
Config/testthat/edition: 3). Stacked on #162.