Revert "feat: add frame-pointers profile option (#16742)"#16999
Merged
Conversation
This is being reverted for now.
rustbot
added
A-build-execution
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-profiles
Contributor
Author
|
I think the version-bump check is unhappy about downgrading the version. I think it should probably resolve itself after this merges. I confirmed that there were no other breaking changes made, so I don't think it is necessary to go to 0.14. |
weihanglo
approved these changes
May 15, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 17, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
May 17, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c95ccc, reversing changes made to da53118.
A concern was raised about the force-off option which may be confusing because it doesn't force them "off", it turns off the "force on" option. Force-off is the default and can change per target.