Adapt release workflow test mocks to action-gh-release v3.0.2 by delthas · Pull Request #2464 · scality/Zenko

delthas · 2026-07-17T12:05:35Z

What does this PR do, and why do we need it?

The check-workflows job fails on every PR based on development/2.14+ since 2026-07-13: softprops/action-gh-release v3.0.2 (picked up automatically via the floating @v3 tag in release.yaml) changed its GitHub API call sequence. Its findTagFromReleases now falls back to listing releases when getReleaseByTag returns 404 — GitHub does not expose draft releases through get-by-tag — and retries the listing up to 3 times. These extra listReleases calls eventually consumed the sequenced mock reply containing the draft release (intended for the post-creation canonicalizeCreatedRelease scan), so the action believed a release already existed and issued a PATCH /releases/123 with draft: true that no mock matches. The unmatched request hangs until undici's headers timeout, and the 5 "Promote artifacts" tests in release.spec.ts each died on the 120s jest timeout.

This PR replaces the sequenced listReleases replies with a single repeated draft-free reply, making the mocks independent of how many listing calls the action makes. The action then creates the release as before and discovers the created draft through the second getReleaseByTag reply alone (pickCanonicalRelease falls back to it when listings contain no match), before publishing it via the existing updateRelease mock.

Which issue does this PR fix?

Fixes ZENKO-5317.

Special notes for your reviewers:

The exact call sequence was confirmed with a DEBUG=nock* trace: the release-notes step makes one listReleases call (the old mock comments claiming two were inaccurate), and the action's fallback makes three.

Issue: ZENKO-5317

bert-e · 2026-07-17T12:05:39Z

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-07-17T13:50:42Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

delthas · 2026-07-17T14:53:17Z

Requested @maeldonn in place of Maha Benzekri, who is currently on PTO.

delthas · 2026-07-19T22:00:31Z

Requested @DarkIsDude in place of Francois Ferrand, who is currently on PTO.

delthas · 2026-07-20T08:30:08Z

Requested @benzekrimaha in place of Edouard Comtet, who is currently away.

bert-e · 2026-07-20T08:31:35Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ZENKO-5317/fix-gh-release-v302-mocks into
development/2.14
w/2.15/improvement/ZENKO-5317/fix-gh-release-v302-mocks will be merged into development/2.15
w/2.16/improvement/ZENKO-5317/fix-gh-release-v302-mocks will be merged into development/2.16

The following branches will NOT be impacted:

development/2.10
development/2.11
development/2.12
development/2.13
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2026-07-20T08:31:36Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

delthas · 2026-07-20T09:18:14Z

/reset

bert-e · 2026-07-20T09:18:16Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Since v3.0.2 (published 2026-07-13, picked up via the floating v3 tag), action-gh-release's findTagFromReleases falls back to listing releases after getReleaseByTag returns 404, to discover existing draft releases, retrying the listing up to maxRetries (3) times. The test mocked only 3 listReleases replies, so a findTagFromReleases retry consumed the reply containing the draft release: the action then took the update-existing-release path and issued an unmatched PATCH, and the 5 'Promote artifacts' tests each hung until the 120s jest timeout. Mock the full listReleases sequence instead: 4 draft-free replies (release-notes generation + the 3 findTagFromReleases attempts), then a draft-bearing reply for the post-creation canonicalizeCreatedRelease scan. None of the pre-creation listings contain the target tag, so the action creates the release as before. Issue: ZENKO-5317

delthas · 2026-07-20T09:51:38Z

/create_integration_branches

bert-e · 2026-07-20T11:44:05Z

History mismatch

Merge commit #38b367b0d3449f00fb5e9bd0b3ccac739776a1cc on the integration branch
w/2.15/improvement/ZENKO-5317/fix-gh-release-v302-mocks is merging a branch which is neither the current
branch improvement/ZENKO-5317/fix-gh-release-v302-mocks nor the development branch
development/2.15.

It is likely due to a rebase of the branch improvement/ZENKO-5317/fix-gh-release-v302-mocks and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

delthas · 2026-07-20T11:45:20Z

/reset

bert-e · 2026-07-20T11:45:31Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2026-07-20T11:45:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

delthas · 2026-07-20T11:47:36Z

/approve

bert-e · 2026-07-20T13:23:58Z

Build failed

The build for commit did not succeed in branch w/2.15/improvement/ZENKO-5317/fix-gh-release-v302-mocks

The following options are set: approve, create_integration_branches

bert-e · 2026-07-20T13:55:54Z

Build failed

The build for commit did not succeed in branch w/2.16/improvement/ZENKO-5317/fix-gh-release-v302-mocks

The following options are set: approve, create_integration_branches

This was referenced Jul 17, 2026

Add CTST coverage for Days=0 lifecycle expiration #2461

Open

Add Cucumber tests for multi-destination CRR #2451

Open

Add CRR cascaded tests #2447

Open

Set default memory resources for the ZooKeeper quorum #2463

Open

scality deleted a comment from bert-e Jul 17, 2026

delthas force-pushed the improvement/ZENKO-5317/fix-gh-release-v302-mocks branch 2 times, most recently from f928d94 to 0ce6772 Compare July 17, 2026 14:44

delthas marked this pull request as ready for review July 17, 2026 14:51

delthas requested review from a team, SylvainSenechal, benzekrimaha, francoisferrand and maeldonn and removed request for benzekrimaha July 17, 2026 14:52

SylvainSenechal approved these changes Jul 17, 2026

View reviewed changes

delthas requested review from DarkIsDude and removed request for francoisferrand July 19, 2026 22:00

delthas force-pushed the improvement/ZENKO-5317/fix-gh-release-v302-mocks branch 2 times, most recently from e1c0f9f to 38b367b Compare July 20, 2026 08:21

delthas requested review from benzekrimaha and removed request for DarkIsDude July 20, 2026 08:30

francoisferrand reviewed Jul 20, 2026

View reviewed changes

Comment thread tests/workflows/release.spec.ts Outdated

francoisferrand reviewed Jul 20, 2026

View reviewed changes

Comment thread tests/workflows/release.spec.ts

delthas force-pushed the improvement/ZENKO-5317/fix-gh-release-v302-mocks branch from 38b367b to e6fd5dc Compare July 20, 2026 09:43

delthas force-pushed the improvement/ZENKO-5317/fix-gh-release-v302-mocks branch from e6fd5dc to f3fdb63 Compare July 20, 2026 09:50

delthas requested a review from francoisferrand July 20, 2026 09:51

francoisferrand approved these changes Jul 20, 2026

View reviewed changes

scality deleted a comment from bert-e Jul 20, 2026

maeldonn approved these changes Jul 20, 2026

View reviewed changes

Uh oh!

Conversation

delthas commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Jul 17, 2026

Hello delthas,

Uh oh!

bert-e commented Jul 17, 2026

Request integration branches

Uh oh!

delthas commented Jul 17, 2026

Uh oh!

delthas commented Jul 19, 2026

Uh oh!

delthas commented Jul 20, 2026

Uh oh!

bert-e commented Jul 20, 2026

Integration data created

Uh oh!

bert-e commented Jul 20, 2026

Waiting for approval

Uh oh!

Uh oh!

Uh oh!

delthas commented Jul 20, 2026

Uh oh!

bert-e commented Jul 20, 2026

Request integration branches

Uh oh!

delthas commented Jul 20, 2026

Uh oh!

bert-e commented Jul 20, 2026

History mismatch

Uh oh!

delthas commented Jul 20, 2026

Uh oh!

bert-e commented Jul 20, 2026

Reset complete

Uh oh!

bert-e commented Jul 20, 2026

Waiting for approval

Uh oh!

delthas commented Jul 20, 2026

Uh oh!

bert-e commented Jul 20, 2026

Build failed

Uh oh!

bert-e commented Jul 20, 2026

Build failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

delthas commented Jul 17, 2026 •

edited

Loading