Skip to content

New guard-range sexp#7606

Open
TheForce172 wants to merge 5 commits into
scp-fs2open:masterfrom
TheForce172:feature/guard-range-by-guarder
Open

New guard-range sexp#7606
TheForce172 wants to merge 5 commits into
scp-fs2open:masterfrom
TheForce172:feature/guard-range-by-guarder

Conversation

@TheForce172

Copy link
Copy Markdown
Member

New guard-range sexp which allows different ranges for different guarders. As requested by Iain baker.

New guard-range sexp which allows different ranges for different guarders
@TheForce172 TheForce172 added feature A totally new sort of functionality Requested by Active Mod A feature request that has been requested by a mod that is actively in development. labels Jul 14, 2026
@MjnMixael

MjnMixael commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Can this not be done as an expansion of the old sexp instead of adding yet another -new sexp? I know there's convention for that but it's not really a user friendly convention.

@TheForce172

TheForce172 commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Not without changeing the old sexp's behaviour which were not allowed to do as it's been in a stable release.

@Sessile-Nomad

Copy link
Copy Markdown

I suspect I'm the only dev who has used the 'old' set-guard-range Sexp since 26 is so new and I have no issue with adding this to the existing Sexp 🙂

@Sessile-Nomad

Copy link
Copy Markdown

I did a poll to ask if anyone had used the set-guard-range Sexp and it looks like no one has except myself, and most people didn't even know it was 'a thing', so I think we can safely add to it without upsetting anyone.

@Goober5000 Goober5000 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a review for this which I'll send over Discord.

@TheForce172

Copy link
Copy Markdown
Member Author

Ok, Is clang having a nervous breakdown today or something? This one makes no sense either?

@MjnMixael

MjnMixael commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Ok, Is clang having a nervous breakdown today or something? This one makes no sense either?

The codebase in general prefers nullptr over NULL always. Just replace it and it should pass.

EDIT: Oh I see.. it's saying there's a NULL on that line when there's clearly not. Uh. That's neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A totally new sort of functionality Requested by Active Mod A feature request that has been requested by a mod that is actively in development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants