QtFRED align object dialog initialization#7644
Open
MjnMixael wants to merge 1 commit into
Open
Conversation
JohnAFernandez
approved these changes
Jul 23, 2026
JohnAFernandez
left a comment
JohnAFernandez
left a comment
Contributor
There was a problem hiding this comment.
Looks basically good. I want to get this in for the nightly because we plan to have tomorrow be just SDL3
github-project-automation
Bot
moved this from Work In Progress (PRs)
to In Review (PRs)
in qtFRED2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a freeze when cycling wings with the Ship Editor open: bulk selection changes fire objectMarkingChanged once per object, and each signal triggered a full dialog rebuild. All selection-driven dialog models (Ship, Wing, Prop, JumpNode, Waypoint, Scene Browser) now coalesce these bursts into a single deferred refresh.
This snowballed into making the Ship Editor aligned with the newer object-dialog architecture: the model owns the Editor subscriptions and emits shipMarkingChanged, while the dialog's legacy updateUi(bool overwrite) + updateColumn* methods were flattened into the canonical initializeUi()/updateUi() split used by the other object dialogs. Style cleanup removed the trivial closeEvent/hideEvent/showEvent overrides (which caused a redundant double-init on every open) and renamed the Wing Editor's refreshAllDynamicCombos() to initializeUi() to match.
Also fixed a latent cargo-combo bug where findText()'s index was tested as a boolean, leaving the combo blank for custom cargo and duplicating the first entry when the cargo matched it.