Conversation
…ement features and hierarchy notifications
…ance AssetsPanel and HierarchyPanel functionality
…lection and navigation features
…ctorPanel with path input handling
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f66c05a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $workingDirectory = getcwd() ?: '.'; | ||
| $assetsRoots = [ | ||
| $workingDirectory, | ||
| $workingDirectory . '/Assets', | ||
| $workingDirectory . '/assets', |
There was a problem hiding this comment.
Resolve texture files from the project directory
The texture preview lookup is rooted at getcwd() instead of the editor's configured project directory, so opening a project via edit --directory <path> from another shell location makes valid relative texture paths resolve against the wrong tree and renders previews as missing/empty. This breaks inspector behavior for a supported launch mode and should use the same project root the editor was initialized with.
Useful? React with 👍 / 👎.
| public static function fromArray(array $data): self | ||
| { | ||
|
|
There was a problem hiding this comment.
Return a DTO instance from fromArray
HierarchyObjectDTO::fromArray is declared to return self but has an empty body, so any call will return null and trigger a runtime TypeError. This makes array-to-DTO deserialization unusable and will fail immediately once the method is invoked.
Useful? React with 👍 / 👎.
This pull request introduces several enhancements and new features to the editor's input handling and scene management. The most significant changes are the addition of mouse event support, expansion of keyboard input capabilities, and the introduction of data transfer objects (DTOs) for scene and hierarchy data. Additionally, a new
SceneLoaderclass is provided for robust scene discovery and loading.Input Handling Improvements:
MouseEvent, including parsing, state management, and utility methods likegetMouseEvent,isLeftMouseButtonDown, andgetCurrentInputinInputandInputManager. [1] [2] [3] [4] [5] [6] [7]Scene and Hierarchy Data Management:
SceneDTOandHierarchyObjectDTOclasses to encapsulate scene and hierarchy data, including serialization and deserialization methods. [1] [2]SceneLoaderclass for resolving asset and scene directories, loading scene data, and extracting hierarchy information from source files.Event System Extension:
HIERARCHY_CHANGEDto the editor's event enumeration for tracking hierarchy updates.These changes collectively improve the editor's input responsiveness, scene management, and data structure clarity.