-
Notifications
You must be signed in to change notification settings - Fork 0
Enhance editor panels with asset management and navigation features #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5fd60a6
feat(editor): enhance AssetsPanel and HierarchyPanel with asset manag…
amasiye a3a1d09
feat(editor): add ConsolePanel and MainPanel with tab navigation; enh…
amasiye 9e75fe2
feat(editor): enhance AssetsPanel and HierarchyPanel with improved se…
amasiye 87faf57
test(editor): add unit tests for AssetsPanel and HierarchyPanel funct…
amasiye 4061cb3
feat(editor): implement input controls and enhance console panel func…
amasiye d8f66c0
feat(editor): add FileDialogModal and PathInputControl; enhance Inspe…
amasiye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
|
|
||
| namespace Sendama\Console\Editor\DTOs; | ||
|
|
||
| use Serializable; | ||
|
|
||
| /** | ||
| * HierarchyObjectDTO class. | ||
| */ | ||
| class HierarchyObjectDTO | ||
| { | ||
| public function __construct( | ||
| public string $name, | ||
| public string $tag = '', | ||
| public array $position = [1, 1], | ||
| public array $rotation = [0, 0], | ||
| public array $scale = [1, 1] | ||
| ) | ||
| { | ||
| } | ||
|
|
||
| public function __serialize(): array | ||
| { | ||
| return [ | ||
| 'name' => $this->name, | ||
| 'tag' => $this->tag, | ||
| 'position' => $this->position, | ||
| 'rotation' => $this->rotation, | ||
| 'scale' => $this->scale | ||
| ]; | ||
| } | ||
|
|
||
| public function __unserialize(array $data): void | ||
| { | ||
| $this->name = $data['name'] ?? ''; | ||
| $this->tag = $data['tag'] ?? ''; | ||
| $this->position = $data['position'] ?? [1, 1]; | ||
| $this->rotation = $data['rotation'] ?? [0, 0]; | ||
| $this->scale = $data['scale'] ?? [1, 1]; | ||
| } | ||
|
|
||
| public static function fromArray(array $data): self | ||
| { | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
|
|
||
| namespace Sendama\Console\Editor\DTOs; | ||
|
|
||
| /** | ||
| * SceneDTO class. Data Transfer Object for scene data in the editor. | ||
| */ | ||
| class SceneDTO | ||
| { | ||
| public function __construct( | ||
| public string $name, | ||
| public int $width = DEFAULT_TERMINAL_WIDTH, | ||
| public int $height = DEFAULT_TERMINAL_HEIGHT, | ||
| public string $environmentTileMapPath = "Maps/example", | ||
| public bool $isDirty = false, | ||
| public array $hierarchy = [], | ||
| ) | ||
| { | ||
| } | ||
|
|
||
| public function __serialize(): array | ||
| { | ||
| return [ | ||
| "name" => $this->name, | ||
| "width" => $this->width, | ||
| "height" => $this->height, | ||
| "environmentTileMapPath" => $this->environmentTileMapPath, | ||
| "isDirty" => $this->isDirty, | ||
| "hierarchy" => $this->hierarchy, | ||
| ]; | ||
| } | ||
|
|
||
| public function __unserialize(array $data): void | ||
| { | ||
| $this->name = $data['name'] ?? ''; | ||
| $this->width = $data['width'] ?? DEFAULT_TERMINAL_WIDTH; | ||
| $this->height = $data['height'] ?? DEFAULT_TERMINAL_HEIGHT; | ||
| $this->environmentTileMapPath = $data['environmentTileMapPath'] ?? "Maps/example"; | ||
| $this->isDirty = $data['isDirty'] ?? false; | ||
| $this->hierarchy = $data['hierarchy'] ?? []; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HierarchyObjectDTO::fromArrayis declared to returnselfbut has an empty body, so any call will returnnulland trigger a runtimeTypeError. This makes array-to-DTO deserialization unusable and will fail immediately once the method is invoked.Useful? React with 👍 / 👎.