ERC-4361 erratum: align grammar, prose, and reference implementation#1
Draft
jwahdatehagh wants to merge 14 commits into
Draft
ERC-4361 erratum: align grammar, prose, and reference implementation#1jwahdatehagh wants to merge 14 commits into
jwahdatehagh wants to merge 14 commits into
Conversation
jwahdatehagh
force-pushed
the
review/4361
branch
from
071159b to
ab3818b
Compare
jwahdatehagh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the ERC-4361 erratum to corrections that are appropriate for a Final ERC: direct contradictions, grammar/prose/reference-implementation mismatches, and explicitly classified compatibility changes.
Most commits are editorial or clarifications. The behavior-affecting changes are intentionally narrow:
userinfo@is excluded from the SIWEdomainfield, aligning the grammar with the origin model used by wallet verification.statementis widened to printable ASCII while preserving parser acceptance of empty and omitted statements.Earlier draft changes for IDN/punycode policy, percent-decoded URI display framing, leading-zero
chain-id, and standalone empty-port rejection were removed from this erratum scope.What changes
14 commits against
ERCS/erc-4361.mdandassets/erc-4361/example.js, ordered low-controversy first.Finding numbers refer to the companion evidence repository.
Backwards compatibility
Audited against the canonical
@signinwithethereum/test-vectorscorpus consumed by the maintained TypeScript, Python, Rust, and Go SIWE libraries.userinfo@indomain) affects 2 positive grammar-completeness vectors. The concurrent test-vectors PR moves them to negative.statementprintable ASCII) updates statement character vectors and should roll out parser-first before producers rely on the wider set.statement, emptyrequest-id, and bareResources:remain parseable. The PR adds producer guidance to prefer omission, not parser rejection.Concurrent release plan
The companion test-vector PR is
signinwithethereum/test-vectors#1. It now covers both surviving behavior changes:userinfo@domain vectors from positive to negativeDownstream library PRs should only implement surviving parser changes: rejecting
userinfo@indomainand accepting the widened statement character set.Evidence
Review guidance
If editors object to a specific commit, name the SHA and the objection. The branch is structured so contested commits can be removed without reopening unrelated corrections.
Filed as an erratum against version 1 of ERC-4361. The status remains Final; no version bump is proposed.