Update test vectors for ERC-4361 erratum#1
Open
jwahdatehagh wants to merge 1 commit into
Open
Conversation
Reclassify userinfo@ domain messages as negative and update statement character vectors for the printable-ASCII widening.
0406344 to
57a170b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the canonical SIWE test vectors for the surviving behavior changes in
signinwithethereum/ERCs#1.Changes:
userinfo@domain vectors from positive to negative, matching the ERC-4361 erratum's exclusion of the RFC 3986userinfosubcomponent from SIWEdomainvalues.statement, while LF and other controls remain excluded.Vectors moved from
vectors/parsing/parsing_positive.jsontovectors/parsing/parsing_negative.json:domain is RFC 3986 authority with userinfo(test@127.0.0.1)domain is RFC 3986 authority with userinfo and port(test@127.0.0.1:8080)Statement vector changes:
vectors/grammar/valid_chars.jsonnow treats full printable ASCII (0x20through0x7E) as valid forstatement.vectors/grammar/invalid_chars.json.Coordination
This PR is held open pending resolution of the ERC-4361 erratum. Downstream SIWE libraries should consume this vector update when they implement the surviving parser changes: reject
userinfo@indomainand accept the widened statement character set.Evidence
See the erratum evidence repository: