Skip to content

silx view: Fixed ensure hdf5 file locking is disabled#4595

Merged
t20100 merged 2 commits into
mainfrom
fix-silx-view-hdf5-file-locking
May 7, 2026
Merged

silx view: Fixed ensure hdf5 file locking is disabled#4595
t20100 merged 2 commits into
mainfrom
fix-silx-view-hdf5-file-locking

Conversation

@t20100
Copy link
Copy Markdown
Member

@t20100 t20100 commented May 7, 2026

PR summary

Set HDF5_USE_FILE_LOCKING before importing hdf5plugin.

related to #4594
partly revert #4376

AI Disclosure

  • No AI used

@t20100 t20100 added this to the Next release milestone May 7, 2026
@t20100 t20100 requested a review from a team May 7, 2026 07:46
@t20100
Copy link
Copy Markdown
Member Author

t20100 commented May 7, 2026

Add preparation of a release.

I propose to make a minor release since there is no new features. The only questionable PR for me is #4560 which adds some typing.

@loichuder
Copy link
Copy Markdown
Member

Is it possible to add a test to avoid this in the future?

@t20100
Copy link
Copy Markdown
Member Author

t20100 commented May 7, 2026

Is it possible to add a test to avoid this in the future?

Yes! I leave issue #4594 opened to add a non regression test, I prefer not to delay the bug fix release.

@t20100 t20100 merged commit 7d891e4 into main May 7, 2026
4 checks passed
@t20100 t20100 deleted the fix-silx-view-hdf5-file-locking branch May 7, 2026 09:11
@woutdenolf
Copy link
Copy Markdown
Contributor

@sergey-yaroslavtsev To be checked that pymca has the same issue.

@sergey-yaroslavtsev
Copy link
Copy Markdown
Contributor

sergey-yaroslavtsev commented May 11, 2026

@sergey-yaroslavtsev To be checked that pymca has the same issue.

Locking should be set before importing hdf5plugin and h5py. No sure why but it is so.
I think it is OK in PyMca now:
1st was introduced silx-kit/pymca#1198 (_init_hdf5() in PyMcaAppInit.py)
2nd was fixed in silx-kit/pymca#1209

@t20100
Copy link
Copy Markdown
Member Author

t20100 commented May 12, 2026

Locking should be set before importing hdf5plugin and h5py. No sure why but it is so.

Now, libhdf5 look at the locking environment variable once when it is loaded.

This issue was only affecting silx view.

@payno
Copy link
Copy Markdown
Member

payno commented May 18, 2026

Maybe we could add some comment on the code linking to this issue in order to avoid reproducing it ? (because personally in 2 months I will have forgot :( )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants