Skip to content

chore: remove dead code in stacks-signer and stacks-node#4

Open
simone-stacks wants to merge 2 commits into
developfrom
quality/dead-code
Open

chore: remove dead code in stacks-signer and stacks-node#4
simone-stacks wants to merge 2 commits into
developfrom
quality/dead-code

Conversation

@simone-stacks

Copy link
Copy Markdown
Owner

Two #[allow(dead_code)]-suppressed items with empty closed callgraphs:

  • RawConfigFile::load_from_file — orphaned since 2023; all callers use GlobalConfig::load_from_file.
  • LastCommit::start_block_hash — write-only field since Jul 2024; removing it also drops a dead .block_hash() computation at the sole call site.

Both items are workspace-internal. Result of a first smoke-test of the quality-agent.

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b7fb888-7e70-4af7-b35f-e41f655c7b0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch quality/dead-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant