Skip to content

chore: remove dead code in stacks-signer and stacks-node #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simone-stacks wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: remove dead code in stacks-signer and stacks-node #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62dbc9e
chore: remove unused RawConfigFile::load_from_file in stacks-signer
simone-stacks May 19, 2026
b5f93d6
chore: drop write-only LastCommit::start_block_hash field
simone-stacks May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions stacks-node/src/nakamoto_node/relayer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ pub struct LastCommit {
stacks_tip: StacksBlockId,
/// the tenure consensus hash for the tip's tenure
tenure_consensus_hash: ConsensusHash,
/// the start-block hash of the tip's tenure
#[allow(dead_code)]
start_block_hash: BlockHeaderHash,
/// What is the epoch in which this was sent?
epoch_id: StacksEpochId,
/// commit txid (to be filled in on submission)
Expand Down Expand Up @@ -223,15 +220,13 @@ impl LastCommit {
burn_tip: BlockSnapshot,
stacks_tip: StacksBlockId,
tenure_consensus_hash: ConsensusHash,
start_block_hash: BlockHeaderHash,
epoch_id: StacksEpochId,
) -> Self {
Self {
block_commit: commit,
burn_tip,
stacks_tip,
tenure_consensus_hash,
start_block_hash,
epoch_id,
txid: None,
}
Expand Down Expand Up @@ -1285,9 +1280,6 @@ impl RelayerThread {
sort_tip,
stacks_tip,
highest_tenure_start_block_header.consensus_hash,
highest_tenure_start_block_header
.anchored_header
.block_hash(),
target_epoch.epoch_id,
))
}
Expand Down
5 changes: 0 additions & 5 deletions stacks-signer/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,11 +479,6 @@ impl RawConfigFile {
toml::from_str(data).map_err(|e| ConfigError::ParseError(format!("{e:?}")))?;
Ok(config)
}
/// load the config from a file and parse it
#[allow(dead_code)]
pub fn load_from_file(path: &str) -> Result<Self, ConfigError> {
Self::try_from(&PathBuf::from(path))
}
}

impl TryFrom<&PathBuf> for RawConfigFile {
Expand Down
Loading