Skip to content

fix(templates) :: let each_row call inline partials - #1580

Merged
lovasoa merged 1 commit into
mainfrom
81reap/issue/846
Oct 30, 2026
Merged

lovasoa merged 1 commit into
mainfrom
81reap/issue/846

Conversation

@81reap

@81reap 81reap commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes #846

Assisted By :: Claude Opus 5.5

Fixes #846

Assisted By :: Claude Opus 5.5
@81reap

81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

reproduction from #846

$ cat tests/end-to-end/fixtures/repro_846/index.sql 
SELECT 'text' AS component, 'repro' AS contents;

$ cat tests/end-to-end/fixtures/repro_846/page.sql 
SELECT 'repro_846' AS component;
SELECT 'a' AS item;
SELECT 'b' AS item;

$ cat tests/end-to-end/fixtures/repro_846/test.ts 
import { expect, test } from "../../fixture.ts";

test("each_row calls an inline partial", async ({ page }) => {
  await page.goto("/repro_846/page.sql");
  await expect(page.locator(".item")).toHaveCount(2);
});
repro_846 postgres
v0.33.0 ✘ failed
v0.47.0 ✘ failed
tree ✔ passed

On commit eb6ef5a: nix run .#reproduce -- repro_846 postgres v0.33.0 v0.47.0 tree

@81reap
81reap marked this pull request as ready for review October 30, 2026 00:42

@lovasoa lovasoa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃👍!

@lovasoa
lovasoa added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit f1c714a Oct 30, 2026
22 checks passed
@81reap
81reap deleted the 81reap/issue/846 branch October 30, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"each_row" helper cannot contain calls to inline partials.

2 participants