Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a task to ensure that python3-packaging is installed on Rocky 10. The reviewer identified a potential issue where the playbook might fail on Rocky 10 by attempting to install non-existent python3.12 packages, and suggested restricting the previous Python 3.12 installation task to Rocky versions prior to 10.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Python 3.12 is now the default for Rocky 10, and we need the `pip` and `packaging` packages installed at a system level for ansible. This change splits out Python system package installation for Rocky 9 and 10, and installs the necessary packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 is now the default for Rocky 10, and we need the
pipandpackagingpackages installed at a system level for ansible. This change splits out Python system package installation for Rocky 9 and 10, and installs the necessary packages.