Fix to factorial.discrete so that it doesn't require custom init_prepare#244
Merged
Conversation
init_preparefactorial.discrete so that it doesn't custom init_prepare
Collaborator
This is related to #245 |
factorial.discrete so that it doesn't custom init_preparefactorial.discrete so that it doesn't require custom init_prepare
Contributor
Author
|
Fixed with minor modification to |
Sahel13
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code for
factorial.discreteis insufficient as it requires overwriting theinit_prepareindiscrete.filter. This isn't ideal asfactorialcode is supposed to work with thecuthbertfilters without modification.I'm wondering about a more holistic fix. Maybe we can replace
FactorializerwithFactorialFilterwhich still has theextract,joinfunctions etc but also hasinit_prepare,filter_prepare,filter_combinewhich are just inherited fromcuthbertor wrapped in the case ofinit_prepare. Although this may create too much code clutter. Will think about it some more