fix: round up sub-satoshi invoice amounts to prevent underpayment#85
Open
ben-kaufman wants to merge 2 commits intomasterfrom
Open
fix: round up sub-satoshi invoice amounts to prevent underpayment#85ben-kaufman wants to merge 2 commits intomasterfrom
ben-kaufman wants to merge 2 commits intomasterfrom
Conversation
Lightning invoices can have millisatoshi precision (e.g. 18557538 msat = 18557.538 sats). The previous floor division (/ 1000) truncated this to 18557 sats, causing payments to fail when the app converted back to msat (18557000 < 18557538 required). Use ceiling division (div_ceil) so amount_satoshis is always sufficient to cover the invoice's msat amount. Closes synonymdev/bitkit-ios#511 Closes synonymdev/bitkit-android#877
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
18557538 msat=18557.538 sats) were truncated by floor division to18557 sats, causingsendUsingAmountto send18557000 msat— less than the invoice requires — and LDK to reject the payment.amount_satoshisfrom floor (/ 1000) to ceiling (div_ceil(1000)) so the sats value always covers the invoice's msat amount..5), exact sat amounts, and boundary cases.Test plan
cargo test scanner— 19 tests passlnd.addInvoice({ valueMsat })using amounts222538,222222,500500msatCloses synonymdev/bitkit-ios#511
Closes synonymdev/bitkit-android#877
🤖 Generated with Claude Code