feat: SW-2054 refine Data App Shell nav rail + workflow step styling#138
Open
GracePan-Tetra wants to merge 3 commits into
Open
feat: SW-2054 refine Data App Shell nav rail + workflow step styling#138GracePan-Tetra wants to merge 3 commits into
GracePan-Tetra wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GracePan-Tetra
changed the title
Replace the demo breadcrumb trail with generic placeholder labels (All Projects / Project Name / worksession name). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a `navRailHidden` prop to DataAppShell. When true, the desktop icon nav rail is not rendered, so collapsing the sidebar panel can hide both the rail and the panel, giving the content full width. Wired in the Default story to the panel's collapsed state, with a play-test asserting the rail is hidden when collapsed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Side nav rail (component): - Narrow rail 60px -> 48px; icon-only nav buttons (label moved to aria-label + tooltip); button box 36px -> 30px; glyphs 20px -> 16px. - Remove divider under the app logo; nudge logo up 4px. - Unify breadcrumb text size to text-sm. Workflow step panel (story demo): - Rename demo steps to generic "Step N Name"; drop per-step counts. - Step card height -> 40px; step name uses the text-title-sm token; inactive steps lightened (font-light). - Remove the INPUT/OUTPUT data-count pills and dead helpers. - Add an outline Back button next to Next from step 2 onward. Play-tests updated to query nav buttons by accessible name and the new labels/sizes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GracePan-Tetra
force-pushed
the
feat/dataappshell-collapsible-rail
branch
from
15afa45 to
20f19ab
Compare
GracePan-Tetra
force-pushed
the
feat/dataappshell-rail-style
branch
from
bb0891e to
a84f94b
Compare
owilliams-tetrascience
approved these changes
Jun 17, 2026
owilliams-tetrascience
left a comment
owilliams-tetrascience
left a comment
Collaborator
There was a problem hiding this comment.
just need to get the e2e test passing and this looks good
owilliams-tetrascience
requested changes
Jun 17, 2026
13 tasks
Copilot AI
added a commit
that referenced
this pull request
Jun 24, 2026
…d counts Three Storybook play-test fixes for PR #138 (feat/dataappshell-rail-style): 1. WorkflowPanelInteractions: remove "1K" count assertion — WorkflowPanel no longer renders inputCount/outputCount pill text. 2. MultipleNavGroups: replace getByText("Filters") / getAllByText("Filters") with getByRole("button", { name: "Filters" }) — nav buttons in the icon rail are now icon-only (label moved to aria-label + tooltip). 3. CompactProperty: update railStyles.width assertion from "60px" to "48px" — rail width changed from w-[60px] to w-12 (48 px).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UI/style pass on the Data App Shell nav rail and the workflow step demo.
Side nav rail (component)
aria-label+ tooltip).text-sm.Workflow step panel (story demo)
text-title-smMD3 token; inactive steps lightened (font-light).formatCount,DataCount,DataCountPills).Before / After
Scope note
Most of the workflow/step changes live in
DataAppShell.stories.tsx(demo code) — no shipped API impact. Real component changes are limited to rail sizing, logo spacing, divider, and breadcrumb font.Checks
yarn lint✅yarn typecheck✅🤖 Generated with Claude Code