fix: return nil from Resource.find on uncastable id#148
Merged
Conversation
Visiting a show/edit URL with an id that can't be cast to the schema's primary key type (e.g. "null" or "abc" for an integer pk) raised Ecto.Query.CastError during connected mount, surfaced as a 400. Rescue the cast error and return nil so the existing "No record found" path renders instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visiting a show/edit URL with an id that can't be cast to the schema's primary key type (e.g.
/foo/show/nullor/foo/edit/abcwhen the pk is an integer) raisedEcto.Query.CastErrorinsideLiveAdmin.Components.Container.handle_params/3during connected mount, which LiveView reports to the client as a 400.Rescue the cast error in
Resource.find/5and returnnil— the existingrecord: nilbranch inComponents.Container.Form.render/1already renders a "No record found" message, so callers see a graceful result instead of a crash.Test plan
/user/edit/not-a-numberasserts the "No record found" message rendersmix test test/live_admin/components/container_test.exs— 31 tests, 0 failures