Skip to content

fix: return nil from Resource.find on uncastable id #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tfwright merged 1 commit into from
Jun 1, 2026
Merged

fix: return nil from Resource.find on uncastable id #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/live_admin/resource.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ defmodule LiveAdmin.Resource do
resource
|> query(nil, config)
|> repo.get(key, prefix: prefix)
rescue
Ecto.Query.CastError -> nil
end

def delete(record, resource, session, repo, config) do
Expand Down
12 changes: 12 additions & 0 deletions test/live_admin/components/container_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,18 @@ defmodule LiveAdmin.Components.ContainerTest do
end
end

describe "edit resource with id that cannot be cast" do
setup %{conn: conn} do
{:ok, view, _} = live(conn, "/user/edit/not-a-number")

%{view: view}
end

test "renders no record found message", %{view: view} do
assert has_element?(view, "*", "No record found")
end
end

describe "edit resource with embed" do
setup %{conn: conn} do
user = Repo.insert!(%User{settings: %{}})
Expand Down
Loading