Repository navigation
chore(deps): bump tinybus 0.3.6, tinytools 0.6.0, tinystoragedrivers 2.1.1 - #121
Merged
Merged
Conversation
Update the vendored tinybus submodule to the latest upstream commit. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the pinned tinytools revision to 41cc80ac so the dependency stays in sync with the gitlink tinyagents pins, keeping tinytools::Tool a single unified type. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the workspace to tinybus 0.3.6 and tinystoragedrivers 2.1.1, refreshing the pinned git revision and the transitive getrandom version. The lockfile and manifests were regenerated to match. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the pinned revision for tinystoragedrivers-types to bf1f0a97 so the bus boundary check tracks the current upstream commit, and adjust the boundary tests to match the new pin. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewReviewed head: FindingsNo active actionable findings. Advisory notes
Verdict: Ready for maintainer review · Priority: medium Diagnostics and supporting detailsFull summaryPull request purpose (title): chore(deps): bump tinybus 0.3.6, tinytools 0.6.0, tinystoragedrivers 2.1.1. Tiny Sweeper completed its review; deterministic results follow. Unreviewed paths
Review snapshot
Completeness: Complete What changedDependency pins move across Cargo.toml and both crate manifests: tinytools to 41cc80ac, tinystoragedrivers types/api/busproxy/testkit to bf1f0a97, and tinybus to 0.3.6 with range >=0.3.6, <0.4. In the root crate, coins-bip32 and coins-bip39 go 0.13 to 0.17, rand 0.9 to 0.10 with added sys_rng/thread_rng features, and k256 goes to 0.14 in the x402 crate. Code is adapted to the new APIs: to_encoded_point becomes to_sec1_point in src/key/bip32.rs, src/key/evm.rs and src/key/mod_tests.rs; sign_prehash_recoverable drops its unwrap in crates/tinywallet-x402/src/test_support/mod.rs; generate_mnemonic in src/key/mod.rs is rewritten around WordCount::try_from and Mnemonic::random. scripts/check-bus-boundaries.py and its test update the TSD rev. Cargo.lock and vendor/tinybus are in the changed-file list but not in the shown diff. Features
Tests
Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Dependency versions and revision pins Cargo.toml, crates/tinywallet-module/Cargo.toml, crates/tinywallet-x402/Cargo.toml, vendor/tinybus, scripts/check-bus-boundaries.py, scripts/check_bus_boundaries_tests.py |
Dependency versions and Git revisions change. The TinyBus submodule and storage-driver boundary checks use updated revisions. |
SEC1 encoding and EVM test signing src/key/bip32.rs, src/key/evm.rs, crates/tinywallet-x402/src/test_support/mod.rs, src/key/mod_tests.rs |
Public-key conversion uses to_sec1_point. The EVM test signer no longer unwraps the recoverable-signature result. The key derivation test uses the updated SEC1 conversion. |
Mnemonic word-count validation src/key/mod.rs |
generate_mnemonic converts the requested count to WordCount before generating a phrase. Unsupported counts return Error::InvalidMnemonicWordCount. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- tinyhumansai/tinywallet#119: Updates the same TinyBus submodule; this PR advances it to a later commit and updates the TinyBus version range.
Suggested reviewers: m3ga-mind
Merge Risk: 
87830
-
The dependency and API updates present no established merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 7 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely identifies the primary dependency updates: tinybus, tinytools, and tinystoragedrivers. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 7 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Clippy (1.99.0)
-
Clippy execution failed
A rabbit checks the keys at dawn
New pins are set, old ones withdrawn
SEC1 points now find their place
Word counts pass through a careful gate
The test signer skips a panic's leap
Then hops away to carrots deep
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Bump the bitcoin, coins-bip32, coins-bip39, and coins-core dependencies to their latest releases and refresh the lockfile accordingly. The upgrade pulls in newer digest, hmac, and sha2 versions and drops the now-unused bitvec and const-hex transitive crates. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Renamed the SEC1 point encoding calls to the current to_sec1_point name and switched mnemonic generation to the WordCount-based random constructor, which validates the requested length up front instead of relying on the older from_rng_with_count helper. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updates the optional rand dependency to 0.10, which pulls in chacha20 and getrandom for the std_rng feature. The lockfile is regenerated to match. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The rand dependency was missing the sys_rng and thread_rng features, so rand::rng() could not be used to seed mnemonic generation from OS entropy. Enabling them restores the intended behaviour, and the generate_mnemonic call site is reformatted to satisfy rustfmt. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The fake payment signer no longer unwraps the result of sign_prehash_recoverable, matching the infallible signature of the call. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
tinysweeper
Bot
added
priority: p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the nested tinybus submodule to v0.3.6 (6ce06bc), the tinybus git pin and version range (>=0.3.6, <0.4), tinytools to v0.6.0 (41cc80a) and tinystoragedrivers to v2.1.1 (bf1f0a9); refreshes Cargo.lock and the bus-boundary script pin. No code changes were needed. Locally: clippy -D warnings, rustdoc -D warnings, fmt, nextest (896 pass), doctests, test-features, test-e2e, coverage and boundary scripts all pass.
Summary by CodeRabbit