Replace the rust usage with a somewhat hacky call to uvx - #9037
Closed
AdamGS wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/tpchgen-rs-replacement
branch
from
July 28, 2026 16:18
1f2423f to
9ee00c3
Compare
github-actions
Bot
removed
the
action/benchmark-sql
AdamGS
added
action/benchmark-sql
github-actions
Bot
removed
the
action/benchmark-sql
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (9)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals Profiling 📖Vortex (geomean): 0.993x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (0.993x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMe 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.291x ❌, 0↑ 9↓)
datafusion / parquet (1.215x ❌, 0↑ 9↓)
duckdb / vortex-file-compressed (1.240x ❌, 0↑ 9↓)
duckdb / parquet (1.138x ❌, 0↑ 8↓)
File Size Changes (2 files changed, -46.3% overall, 0↑ 2↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.072x ➖, 0↑ 24↓)
datafusion / parquet (1.070x ➖, 0↑ 22↓)
duckdb / vortex-file-compressed (1.035x ➖, 0↑ 5↓)
duckdb / parquet (1.026x ➖, 0↑ 3↓)
File Size Changes (25 files changed, -43.5% overall, 0↑ 25↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Verdict: Likely regression (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
datafusion / parquet (0.456x ✅, 22↑ 0↓)
duckdb / vortex-file-compressed (1.011x ➖, 0↑ 2↓)
duckdb / parquet (0.544x ✅, 22↑ 0↓)
File Size Changes (17 files changed, -44.3% overall, 2↑ 15↓)
Totals:
|
Contributor
Benchmarks: Clickbench Sorted on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.985x ➖, 1↑ 1↓)
datafusion / parquet (1.027x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.046x ➖, 0↑ 2↓)
duckdb / parquet (1.052x ➖, 0↑ 1↓)
File Size Changes (201 files changed, -42.8% overall, 40↑ 161↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.055x ➖, 0↑ 4↓)
datafusion / parquet (0.882x ✅, 7↑ 1↓)
duckdb / vortex-file-compressed (1.039x ➖, 0↑ 4↓)
duckdb / parquet (0.882x ✅, 9↑ 6↓)
File Size Changes (48 files changed, -44.5% overall, 5↑ 43↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.006x ➖, 0↑ 1↓)
datafusion / parquet (0.950x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.993x ➖, 0↑ 0↓)
duckdb / parquet (1.036x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population Genetics 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.993x ➖, 1↑ 0↓)
duckdb / parquet (1.010x ➖, 0↑ 0↓)
File Size Changes (2 files changed, -32.3% overall, 0↑ 2↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.896x ➖, 1↑ 0↓)
datafusion / parquet (0.946x ➖, 5↑ 4↓)
duckdb / vortex-file-compressed (1.038x ➖, 0↑ 0↓)
duckdb / parquet (0.904x ➖, 1↑ 1↓)
|
Contributor
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.958x ➖, 3↑ 0↓)
datafusion / parquet (0.971x ➖, 3↑ 1↓)
duckdb / vortex-file-compressed (0.947x ➖, 4↑ 0↓)
duckdb / parquet (0.983x ➖, 0↑ 1↓)
File Size Changes (101 files changed, -39.2% overall, 0↑ 101↓)
Totals:
|
AdamGS
changed the title
AdamGS
changed the title
AdamGS
marked this pull request as ready for review
July 28, 2026 17:15
github-actions
Bot
removed
the
action/benchmark-sql
Merging this PR will improve performance by 16.76%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
350.6 µs | 300.3 µs | +16.76% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/tpchgen-rs-replacement (cd229be) with develop (6609288)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Author
|
Closing in favor of doing the same in rust code for now, will remove that too in a future PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The git dependency is an annoying hack. We also don't write bloom filters for every chunk of every column, which makes the Parquet files MUCH smaller, which turns out to be very important at small scales.
This does require users to have
uvxinstalled, but we already have a bunch of other dependencies on those.